From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga11.intel.com ([192.55.52.93]:11224 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751474AbcFBI2G (ORCPT ); Thu, 2 Jun 2016 04:28:06 -0400 Message-ID: <574FEE13.30500@intel.com> Date: Thu, 02 Jun 2016 16:28:03 +0800 From: "Yong, Jonathan" MIME-Version: 1.0 To: Darren Hart , Guenter Roeck CC: linux-watchdog@vger.kernel.org, platform-driver-x86@vger.kernel.org, qipeng.zha@intel.com Subject: Re: [PATCH 2/2] x86: Fix Apollo Lake Watchdog address in PMC driver References: <1463541972-19758-1-git-send-email-jonathan.yong@intel.com> <1463541972-19758-3-git-send-email-jonathan.yong@intel.com> <573BE985.1000306@roeck-us.net> <573BF421.2020503@intel.com> <573C7E0C.7050304@roeck-us.net> <20160524201316.GA5857@f23x64.localdomain> <57455A8B.1090807@intel.com> In-Reply-To: <57455A8B.1090807@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 05/25/2016 15:55, Yong, Jonathan wrote: > On 05/25/2016 04:13, Darren Hart wrote: >> >> The history of this driver is for Apollo Lake, so the question is if >> there exist >> v3 and v5 APL products, or if we only need to concern ourselves with >> v5 in the >> upstream driver. >> >> Especially given the "I don't know if this is the right way" in the cover >> letter, I will need an Acked-by at the very least from Qipeng. >> > > Hi Qipeng, > > Do you know the history behind drivers/platform/x86/intel_pmc_ipc.c? > Were the specs based on earlier prototypes? > Qipeng, ping?