From: Guenter Roeck <linux@roeck-us.net>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Wim Van Sebroeck <wim@iguana.be>,
Martyn Welch <martyn.welch@collabora.com>
Subject: Re: [PATCH 1/2] watchdog: ziirave_wdt: Correct I2C device id to fix module autoloading.
Date: Fri, 17 Jun 2016 06:23:38 -0700 [thread overview]
Message-ID: <5763F9DA.1070300@roeck-us.net> (raw)
In-Reply-To: <1466160754-15599-2-git-send-email-enric.balletbo@collabora.com>
On 06/17/2016 03:52 AM, Enric Balletbo i Serra wrote:
> The I2C core removes the manufacturer prefix from the compatible field
> so it reports to user-space the uevent i2c:rave-wdt, but this doesn't
> match with the i2c_device_id (i2c:ziirave-wdt) array so the module is not
> autoloaded. Correct the I2C device id to match with the reported uevent
> and fix the module autoloading functionality.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/ziirave_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c
> index cbe373de..fa1efef 100644
> --- a/drivers/watchdog/ziirave_wdt.c
> +++ b/drivers/watchdog/ziirave_wdt.c
> @@ -339,7 +339,7 @@ static int ziirave_wdt_remove(struct i2c_client *client)
> }
>
> static struct i2c_device_id ziirave_wdt_id[] = {
> - { "ziirave-wdt", 0 },
> + { "rave-wdt", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(i2c, ziirave_wdt_id);
>
next prev parent reply other threads:[~2016-06-17 13:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 10:52 [PATCH 0/2] watchdog: ziirave_wdt: Support firmware update Enric Balletbo i Serra
2016-06-17 10:52 ` [PATCH 1/2] watchdog: ziirave_wdt: Correct I2C device id to fix module autoloading Enric Balletbo i Serra
2016-06-17 13:23 ` Guenter Roeck [this message]
2016-07-17 20:08 ` Wim Van Sebroeck
2016-06-17 10:52 ` [PATCH 2/2] watchdog: ziirave_wdt: Add support to upload the firmware Enric Balletbo i Serra
2016-07-18 21:43 ` Martyn Welch
2016-07-20 10:05 ` Enric Balletbo Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5763F9DA.1070300@roeck-us.net \
--to=linux@roeck-us.net \
--cc=enric.balletbo@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=martyn.welch@collabora.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).