From: Guenter Roeck <linux@roeck-us.net>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
James Hilliard <james.hilliard1@gmail.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
Subject: Re: [PATCH v3 1/2] watchdog: it87_wdt: Don't use "proxy" headers
Date: Wed, 16 Jul 2025 17:24:55 -0700 [thread overview]
Message-ID: <5e471ef4-5303-4c7f-a7fa-e19f8fea0f8f@roeck-us.net> (raw)
In-Reply-To: <20250708133646.70384-2-andriy.shevchenko@linux.intel.com>
On 7/8/25 06:33, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Note that kernel.h is discouraged to be included as it's written
> at the top of that file.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/it87_wdt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/it87_wdt.c b/drivers/watchdog/it87_wdt.c
> index a1e23dce8810..3b8488c86a2f 100644
> --- a/drivers/watchdog/it87_wdt.c
> +++ b/drivers/watchdog/it87_wdt.c
> @@ -22,11 +22,13 @@
>
> #include <linux/bits.h>
> #include <linux/dmi.h>
> +#include <linux/errno.h>
> #include <linux/init.h>
> #include <linux/io.h>
> -#include <linux/kernel.h>
> +#include <linux/ioport.h>
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> +#include <linux/printk.h>
> #include <linux/types.h>
> #include <linux/watchdog.h>
>
next prev parent reply other threads:[~2025-07-17 0:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 13:33 [PATCH v3 0/2] watchdog: Don't use "proxy" inclusions Andy Shevchenko
2025-07-08 13:33 ` [PATCH v3 1/2] watchdog: it87_wdt: Don't use "proxy" headers Andy Shevchenko
2025-07-17 0:24 ` Guenter Roeck [this message]
2025-07-08 13:33 ` [PATCH v3 2/2] watchdog: " Andy Shevchenko
2025-07-17 0:25 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e471ef4-5303-4c7f-a7fa-e19f8fea0f8f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=james.hilliard1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox