From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00C6C22A4F6; Sat, 18 Oct 2025 15:48:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760802487; cv=none; b=N82IlXYl1FzwLS3MdZM8XYKdk7Emh/yO5o+9mrFc3md3GaZGWLDFPhLP/V9EP736yoLxldXXN+7NpHztNQqoo/BMk10Y3uMGuzLz4xhT1lMxbjxZjs2fzP3mtHo7I6cX/XGqxz6Zv0eCU93XmEqBfNDQ9r1nOUBJh6NQwaQCCiA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760802487; c=relaxed/simple; bh=uWpgtJP0YNgQKbW0W4SOynO/zeJGsLOB4hD//kdY9lI=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=Yi659J33TthZaIlvtpXKG717afZ7AkehrXr7sP4Xof60MDk0oSvX/tbaYzgrQZgloEnxVqDnkA/8Ut8kQb483xWklOOu31vMYPjPTBVp8sAGuA+521O8kDfXVwOBRkMPrjYU2asio+Qaa+UKOpsJusohkkBtiWEAenPwtINgrFY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WVjJAsYn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WVjJAsYn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21342C4CEF9; Sat, 18 Oct 2025 15:48:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760802486; bh=uWpgtJP0YNgQKbW0W4SOynO/zeJGsLOB4hD//kdY9lI=; h=Date:Subject:To:References:From:In-Reply-To:From; b=WVjJAsYnK50+OmDWMpm447pSJuu+0PM8ZmSA+OU+8zPlI1EzxYtjju36RCkHI4gbb Hbnz/+w1fEBo89md7DVekAOLwhPpooibsFZ2qGEFglCYD5fJJJhwP9zuAbYQPTeD6I 8Q+1+PemyT0TEj5nFdGbrEC8/e5XDtSCu+eO9hNW+/AXw6yrIA0Z5e9ao5sqirY+UG a+t0V9FoUvjj9X04G7KtgXsuGxX80Tpehaf4Qmty7by/Ym0jmi3aVGEe7pp30Rq4r8 Ekt87OhoGyVe7i6k5qK1nDqRY2o868sh7RswvStcr3HC4LfqH4I8Q+yO5ZCaW48AkF jEkauT/Y3Aciw== Message-ID: <6215c723-aeb2-4ef5-940a-a70806c1576f@kernel.org> Date: Sat, 18 Oct 2025 17:48:02 +0200 Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dt-bindings: watchdog: lantiq,wdt: convert bindings to dtschema To: Aleksander Jan Bajkowski , wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, hauke@hauke-m.de, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251018093229.291419-1-olek2@wp.pl> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20251018093229.291419-1-olek2@wp.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18/10/2025 11:29, Aleksander Jan Bajkowski wrote: > Convert the Lantiq WDT Watchdog bindings to yaml format. > > Signed-off-by: Aleksander Jan Bajkowski > --- > v2: > - requirement of lantiq,rcu is now expressed as a schema > --- > .../bindings/watchdog/lantiq,wdt.yaml | 63 +++++++++++++++++++ > .../bindings/watchdog/lantiq-wdt.txt | 24 ------- > 2 files changed, 63 insertions(+), 24 deletions(-) > create mode 100644 Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml > delete mode 100644 Documentation/devicetree/bindings/watchdog/lantiq-wdt.txt > > diff --git a/Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml b/Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml > new file mode 100644 > index 000000000000..204e16be2a79 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/lantiq,wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Lantiq WTD watchdog > + > +maintainers: > + - Hauke Mehrtens > + > +properties: > + compatible: > + oneOf: > + - enum: > + - lantiq,falcon-wdt > + - lantiq,wdt > + - lantiq,xrx100-wdt > + - items: > + - enum: > + - lantiq,xrx200-wdt > + - lantiq,xrx300-wdt This wasn't in the old binding. Any change from pure conversion has to be explained WHY in the commit msg. What is more - it does not exist. You cannot just stuff here new compatibles and call it "conversion". Conversion from dev/null into new compatible? > + - const: lantiq,xrx100-wdt > + > + reg: > + maxItems: 1 > + > + lantiq,rcu: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: Phandle to the RCU syscon node > + > +required: > + - compatible > + - reg > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: lantiq,xrx100-wdt > + then: > + required: > + - lantiq,rcu > + - if: > + properties: > + compatible: > + contains: > + const: lantiq,falcon-wdt That's just enum in previous contains. > + then: > + required: > + - lantiq,rcu Missing ref to watchdog. Otherwise why do you have unevaluatedProperties? > + > +unevaluatedProperties: false Best regards, Krzysztof