* [PATCH] watchdog: coh901327: make license text and module licence match
@ 2018-02-10 9:27 Marcus Folkesson
2018-02-10 15:32 ` Guenter Roeck
2018-02-22 13:59 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Marcus Folkesson @ 2018-02-10 9:27 UTC (permalink / raw)
To: Linus Walleij, Wim Van Sebroeck, Guenter Roeck
Cc: Marcus Folkesson, linux-arm-kernel, linux-watchdog, linux-kernel
Licence text is specifying "GPLv2" but the MODULE_LICENSE is set to "GPLv2
or later".
See include/linux/module.h:
"GPL" [GNU Public License v2 or later]
"GPL v2" [GNU Public License v2]
When on it, add SPDX identifier tag.
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
drivers/watchdog/coh901327_wdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c
index 5d8eb9a30879..7b71e0a3e6cc 100644
--- a/drivers/watchdog/coh901327_wdt.c
+++ b/drivers/watchdog/coh901327_wdt.c
@@ -1,8 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
/*
* coh901327_wdt.c
*
* Copyright (C) 2008-2009 ST-Ericsson AB
- * License terms: GNU General Public License (GPL) version 2
* Watchdog driver for the ST-Ericsson AB COH 901 327 IP core
* Author: Linus Walleij <linus.walleij@stericsson.com>
*/
@@ -420,5 +420,5 @@ MODULE_DESCRIPTION("COH 901 327 Watchdog");
module_param(margin, uint, 0);
MODULE_PARM_DESC(margin, "Watchdog margin in seconds (default 60s)");
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");
MODULE_ALIAS("platform:coh901327-watchdog");
--
2.15.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: coh901327: make license text and module licence match
@ 2018-02-10 14:53 Philippe Ombredanne
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Ombredanne @ 2018-02-10 14:53 UTC (permalink / raw)
To: Marcus Folkesson
Cc: Linus Walleij, Wim Van Sebroeck, Guenter Roeck,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-watchdog, LKML
On Sat, Feb 10, 2018 at 10:27 AM, Marcus Folkesson
<marcus.folkesson@gmail.com> wrote:
> Licence text is specifying "GPLv2" but the MODULE_LICENSE is set to "GPLv2
> or later".
>
> See include/linux/module.h:
> "GPL" [GNU Public License v2 or later]
> "GPL v2" [GNU Public License v2]
>
> When on it, add SPDX identifier tag.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
> drivers/watchdog/coh901327_wdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c
> index 5d8eb9a30879..7b71e0a3e6cc 100644
> --- a/drivers/watchdog/coh901327_wdt.c
> +++ b/drivers/watchdog/coh901327_wdt.c
> @@ -1,8 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * coh901327_wdt.c
> *
> * Copyright (C) 2008-2009 ST-Ericsson AB
> - * License terms: GNU General Public License (GPL) version 2
> * Watchdog driver for the ST-Ericsson AB COH 901 327 IP core
> * Author: Linus Walleij <linus.walleij@stericsson.com>
> */
> @@ -420,5 +420,5 @@ MODULE_DESCRIPTION("COH 901 327 Watchdog");
> module_param(margin, uint, 0);
> MODULE_PARM_DESC(margin, "Watchdog margin in seconds (default 60s)");
>
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
> MODULE_ALIAS("platform:coh901327-watchdog");
Thank you!
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
--
Cordially
Philippe Ombredanne
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: coh901327: make license text and module licence match
2018-02-10 9:27 [PATCH] watchdog: coh901327: make license text and module licence match Marcus Folkesson
@ 2018-02-10 15:32 ` Guenter Roeck
2018-02-22 13:59 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2018-02-10 15:32 UTC (permalink / raw)
To: Marcus Folkesson, Linus Walleij, Wim Van Sebroeck
Cc: linux-arm-kernel, linux-watchdog, linux-kernel
On 02/10/2018 01:27 AM, Marcus Folkesson wrote:
> Licence text is specifying "GPLv2" but the MODULE_LICENSE is set to "GPLv2
> or later".
>
> See include/linux/module.h:
> "GPL" [GNU Public License v2 or later]
> "GPL v2" [GNU Public License v2]
>
> When on it, add SPDX identifier tag.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/coh901327_wdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c
> index 5d8eb9a30879..7b71e0a3e6cc 100644
> --- a/drivers/watchdog/coh901327_wdt.c
> +++ b/drivers/watchdog/coh901327_wdt.c
> @@ -1,8 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * coh901327_wdt.c
> *
> * Copyright (C) 2008-2009 ST-Ericsson AB
> - * License terms: GNU General Public License (GPL) version 2
> * Watchdog driver for the ST-Ericsson AB COH 901 327 IP core
> * Author: Linus Walleij <linus.walleij@stericsson.com>
> */
> @@ -420,5 +420,5 @@ MODULE_DESCRIPTION("COH 901 327 Watchdog");
> module_param(margin, uint, 0);
> MODULE_PARM_DESC(margin, "Watchdog margin in seconds (default 60s)");
>
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
> MODULE_ALIAS("platform:coh901327-watchdog");
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: coh901327: make license text and module licence match
2018-02-10 9:27 [PATCH] watchdog: coh901327: make license text and module licence match Marcus Folkesson
2018-02-10 15:32 ` Guenter Roeck
@ 2018-02-22 13:59 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2018-02-22 13:59 UTC (permalink / raw)
To: Marcus Folkesson
Cc: Wim Van Sebroeck, Guenter Roeck, Linux ARM, LINUXWATCHDOG,
linux-kernel@vger.kernel.org
On Sat, Feb 10, 2018 at 10:27 AM, Marcus Folkesson
<marcus.folkesson@gmail.com> wrote:
> Licence text is specifying "GPLv2" but the MODULE_LICENSE is set to "GPLv2
> or later".
>
> See include/linux/module.h:
> "GPL" [GNU Public License v2 or later]
> "GPL v2" [GNU Public License v2]
>
> When on it, add SPDX identifier tag.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-22 13:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-10 9:27 [PATCH] watchdog: coh901327: make license text and module licence match Marcus Folkesson
2018-02-10 15:32 ` Guenter Roeck
2018-02-22 13:59 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2018-02-10 14:53 Philippe Ombredanne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).