From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36714C6FD18 for ; Wed, 19 Apr 2023 20:18:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231423AbjDSUS0 (ORCPT ); Wed, 19 Apr 2023 16:18:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231251AbjDSUSZ (ORCPT ); Wed, 19 Apr 2023 16:18:25 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FE12558E for ; Wed, 19 Apr 2023 13:18:23 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id vc20so1237397ejc.10 for ; Wed, 19 Apr 2023 13:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681935502; x=1684527502; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6pbzo4OluoRMXV+MR3P7u+CXjqXd/it4CqxiYCU0P9A=; b=btV0gK2VFbXrK3woTgBAayGrxear9h3tidO6nMICtFU+IhyWrj/M/Jh7hjisWBc1Zx XKY66a2n6iL+1jau2DCE8eAZrBI239NA+MIQyKnF5cgpnHfIXJeXiDSw4Al9tbxJUmtj mzWnMSQawuJ368G4GLTCYa2HLPWrmBSeLdIf6T+0OWLmKgOz9gU10KXgC/3kGal6DDHG WNCCA9EOovlQDyu2ALQe1gFLx56qgtAWAl1Dm0E3Iy9YKxj8n2pox7xJ3igCpK5qVf2E xUJFLdKuUkHOpIuPZDo5a//c7BTTtV1ZS098nYzt262A6vjsL3lOaGKKliz/aKNRVukd D8mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681935502; x=1684527502; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6pbzo4OluoRMXV+MR3P7u+CXjqXd/it4CqxiYCU0P9A=; b=ddiX4XLcHwNa3VlgcBsZ3vZJ9Hq31CnJWy19H9x/IIq2sPe1yYSfSm6cYdEsPJVwYC RSkfeVBNBaJ8sztSbGAY3fIm44/tAclFIbHn6E1fVY+ulmqlH0d/ucRiOP3zavZXhKDh LfDm2H1HdwaoJAnWFordKAipu2TGSkNmunUxlPohqwD7p0YV1BpKW4Q+hxpgMOkAn6Uy 9P29dScHTe8BwkALplapzcYa+13dxGG8MP/Z2DS+1YQvGf77ljzlAhObFYCN8sozUHgD +s3yj7xpvXMdId+aWFk/mP6Y6bhzILOD971+3ybjAqwvWXSvHvHypeMOLc/XZtGW5e8Z X+gg== X-Gm-Message-State: AAQBX9cQv21x+ChR2E/lIYqPb7p5gXxMPoGZrD+oqv1Kli1Oftsi7hY/ EyCs8vYGNCDjA+MKsdNJKPeB031Hb/o7aXz2YtDJPA== X-Google-Smtp-Source: AKy350aPYDtN4ck6FY3wvdtXBvqts4HMhVtEKMJkuZRG6iceMxMu0/SFu7q2kDFyXRuOy1kw1nJLJg== X-Received: by 2002:a17:906:3790:b0:94a:845c:3529 with SMTP id n16-20020a170906379000b0094a845c3529mr14378455ejc.9.1681935501841; Wed, 19 Apr 2023 13:18:21 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:976c:1d6c:6ed0:8935? ([2a02:810d:15c0:828:976c:1d6c:6ed0:8935]) by smtp.gmail.com with ESMTPSA id fl3-20020a1709072a8300b0094f396c7a7asm6052425ejc.214.2023.04.19.13.18.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Apr 2023 13:18:21 -0700 (PDT) Message-ID: <6c4dadfb-b92f-3e95-1d56-de033d560eba@linaro.org> Date: Wed, 19 Apr 2023 22:18:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/2 v2] dt-bindings: watchdog: marvell octeonTX2 GTI system watchdog driver Content-Language: en-US To: Bharat Bhushan , wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sgoutham@marvell.com References: <20230419120635.3736-1-bbhushan2@marvell.com> From: Krzysztof Kozlowski In-Reply-To: <20230419120635.3736-1-bbhushan2@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 19/04/2023 14:06, Bharat Bhushan wrote: > Add binding documentation for the Marvell octeonTX2 > GTI system watchdog driver. > > Signed-off-by: Bharat Bhushan > --- > v2: > - compatible changed from marvell-octeontx2-wdt to marvell,octeontx2-wdt > - corrected type atchdog to watchdog > - Replaced hardcoding to use IRQ_TYPE_EDGE_RISING flag > > .../watchdog/marvell,octeontx2-wdt.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yaml b/Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yaml > new file mode 100644 > index 000000000000..96a979c4082d > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/marvell,octeontx2-wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Marvell OcteonTX2 GTI system watchdog > + > +allOf: > + - $ref: watchdog.yaml# > + > +maintainers: > + - Bharat Bhushan > + > +properties: > + compatible: > + const: marvell,octeontx2-wdt > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + watchdog@802000040000 { > + compatible = "marvell,octeontx2-wdt"; Mixed indentation. Use 4 spaces for entire DTS example (or 2 spaces, but 4 is preferred). Best regards, Krzysztof