From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5D3725C81C for ; Fri, 2 May 2025 16:01:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746201695; cv=none; b=qrpGcUZq2ul63BKAXzk79iewWl2+h3Tm5NHvt6T8LJ/C5xn9ic0Pq24kiLGcTqmmCgKXWia/J4Axnkw5my7iKjepNUkIwuRcy2jVAfFUqToTWTQqoURNh+pgxpgo/nB9z3IwdwQUWE4B3W2C7dT7uNPBeF6XacPRDPDHVbubzXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746201695; c=relaxed/simple; bh=oEvN69p8sBgWkmJUdXqCwtQw+r14F79DPd3s+SqCWqE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pPSYwaGXH75vPRGjR3QiYAn82QT5AkXY27UAhesVr21tOVtg7l/VKUiLaV/SoZSxd8Cl7HJ/Q6KQ9M+lXnIj2tx/Fm6TxXfHbtiNwB4YMkZ4hDO+pxnMXhjPhQBryKlIni3uQsp0KCgXRyP8g5sNqy53tj4Ui3x9hzlnZ5N+vHI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aB/aR1F1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aB/aR1F1" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 542DSVrj002480 for ; Fri, 2 May 2025 16:01:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YoReAk4HgTq2VsfM4ooMcOtk4AFKsH6ALJtlrQXG0fM=; b=aB/aR1F10eANzjIY sR/ixTlWHd0ANoXvrWUHjtGL5eEj6dlk2O/HnenQs91SuOQ1HXgsQVQTjrL+ZmcJ DbT8YyFZ5lfpBVEQ2tcW1OjZn8zRX1GnnnHrBBPjhxTazhNz5rkRsnozaGIAbNFa PVUtrTTQLlrB8dY2lqWBWenm2pSph9wRFx74NSpFCDAkU82dYF9wMgBk5yDdUf19 gAfChMax23Dtdy948wf98TVgZumjMKbpJaRwP2ygd8CV6eklO3W6OUs2XYFAtibs 3ghT6Uie0Gz1zxDj/3rxRU82exkvGe/HwYUuNVGLAbANKYP3KW1ravUBveUz3yaT F58p9Q== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46b6u78vw7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 02 May 2025 16:01:31 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-224347aef79so31099565ad.2 for ; Fri, 02 May 2025 09:01:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746201691; x=1746806491; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YoReAk4HgTq2VsfM4ooMcOtk4AFKsH6ALJtlrQXG0fM=; b=jQFEFrPzXlQRIfm3GUWu32Jl/22Vq8AzpZmF+CjksiO3ae/9z30MNeckLpfYnm/gJV 8ed3okiUyLzeVXbPnz0byLexI9rn3fpwogZhl5LgOQecDo62/3H/BoSdcHDgsck8HWHp CcUP9oBLH6VoCDy0KEzYRpNyuiLmsXL5ITctAPlYViHHgXtiE+aXTnRKljkS364Kq6QV apI53C11ikPPI7OojW9FO64laG7PbTMTWrENQAREvE4uIlNcvZpF6MOq62LB61xswu8g NBc9NTV9JJHf9GxLYhSMmmOpYa/vN/sAuX7PDqSgLhMiiwuauHir9EXn83ACAoKQ9Hdk oyfA== X-Forwarded-Encrypted: i=1; AJvYcCU9bWjj7nO3h0SykMY77mtPGboCl1SZRROpn7hffJBG5ki5gVYIhCTIX/utKiTCdv4b8ycn4OGcPAGrhocCOg==@vger.kernel.org X-Gm-Message-State: AOJu0YzMo3cCyBDBXQy5aLHuxlc1YxRreVAUrDukOVvVQD896m0/oKVJ t6eGi0jWRJhWkWq0jF84WDdEWIfeTxnuczqsx23d6bEug5Zx7uFx1pyocngX1d99E0StPOIAGXT 8rBebLMFyHK8VLfcT8VK1hQMCh6nXLEYDDsjkzCl89uhpO2zzdZQf6x8hv2bEq65OGw== X-Gm-Gg: ASbGncvhKnHfhiFsy9ev6+X82Y3SWSFna5+59wpja7wGA0cBMQOtPV5Bb/FpJVvaUpw 7GMO19Sxlu5v0a0L24t/dNXOY/IRxOY+6MMaOWj5AWgpZjrVYGsF8bLYLSoCnQGE3iyjwLPC+Us dRZTT5SP3/qu3nZrk+xr5XrrxeB1znC/ydYLEdn/lFfcmyYsVxEDM6WQe/7mgrQT5K6CQfMUzEU 2p5xoqr+pG/CWdV2xhmKWA1tvhGcreEcVJ2N6+rx7nMWOPyTl0TEl3JvCBsOzPF+xcd1xF7Mlsu wB3EGrrENSkVSQoa+/xqj0XwIS57hACs9Q16m8MoUCwVX0b6U017 X-Received: by 2002:a17:903:3b86:b0:223:65a9:ab86 with SMTP id d9443c01a7336-22e1031f4b8mr53002955ad.12.1746201690553; Fri, 02 May 2025 09:01:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErV0e0vKI/fgoke9Y2Vn/UmFB0sglBHDOVAnYcG02t9Gkratp9oD7qJCWDutzkAvG97npa/Q== X-Received: by 2002:a17:903:3b86:b0:223:65a9:ab86 with SMTP id d9443c01a7336-22e1031f4b8mr53002545ad.12.1746201690057; Fri, 02 May 2025 09:01:30 -0700 (PDT) Received: from [192.168.1.4] ([122.164.87.156]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b1fb3920e67sm952740a12.7.2025.05.02.09.01.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 May 2025 09:01:29 -0700 (PDT) Message-ID: <6d8f31ed-daaf-4ba2-9e84-227ab798ec5a@oss.qualcomm.com> Date: Fri, 2 May 2025 21:31:22 +0530 Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] watchdog: qcom: introduce the device data for IPQ5424 watchdog device Content-Language: en-US To: Dmitry Baryshkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Wim Van Sebroeck , Guenter Roeck , bod.linux@nxsw.ie, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org References: <20250502-wdt_reset_reason-v3-0-b2dc7ace38ca@oss.qualcomm.com> <20250502-wdt_reset_reason-v3-3-b2dc7ace38ca@oss.qualcomm.com> <4fvlhcztwqw3sp4wb32rbvdra5ativo5zypeokpglzezkmjfmy@vogadyshroix> From: Kathiravan Thirumoorthy In-Reply-To: <4fvlhcztwqw3sp4wb32rbvdra5ativo5zypeokpglzezkmjfmy@vogadyshroix> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTAyMDEyNyBTYWx0ZWRfX9DPgD3jzRZM/ zc8gr6YrC0UV1bcoeeTQKigNUPBlqtNs3PWtAN5RD+pBwGQAzRlwqwZSlulmizpNABFJ5ESMOF4 zgjnHn8jlKElYXIWgb/A2QK9iox/m4+4L4uz1oRr2L450tIUi5CuxjOYBTQKvWVDa2RgutNtBXb EkO09NgRK6QQZkqia1st/1QdnKrOXlx57ITvo+9QiS6aNMoIaSwoYzWn0MQr3qYYi+ybBPPhrVf QuaSJhKfdwEm6xIcWmr7SQ/idZWBKGjchDWojdJtPVikAC+8n4hBugzBnc+x2McneUtdv4gFBZl UbTJp3XcDfJQJC4yC/Wp36Wzq1BWnJoAswALRXfn1015gNLvBUqLmxS1ONb8ubOBnhDzHLd577R fpcs7ZUOU4bkfH9P8+bKmu3HrKLnB9+K78bCksyKdf4RjvtURMQH/7qOBDQmOpjJyGPMojl8 X-Proofpoint-GUID: PXFjlF5qDicBNnCXe_qJVTXIfa4ZUecw X-Authority-Analysis: v=2.4 cv=W404VQWk c=1 sm=1 tr=0 ts=6814ec5b cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=wj/iefQKNY9P1RSDfSoyGA==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=EUspDBNiAAAA:8 a=--xdvnZNnXTZpBI9SIwA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: PXFjlF5qDicBNnCXe_qJVTXIfa4ZUecw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-02_02,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 bulkscore=0 spamscore=0 clxscore=1015 phishscore=0 impostorscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505020127 On 5/2/2025 8:23 PM, Dmitry Baryshkov wrote: > On Fri, May 02, 2025 at 06:47:51PM +0530, Kathiravan Thirumoorthy wrote: >> To retrieve the restart reason from IMEM, certain device specific data >> like IMEM compatible to lookup, location of IMEM to read, etc should be >> defined. To achieve that, introduce the separate device data for IPQ5424 >> and add the required details subsequently. >> >> Signed-off-by: Kathiravan Thirumoorthy >> --- >> Changes in v3: >> - New patch >> --- >> drivers/watchdog/qcom-wdt.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c >> index 006f9c61aa64fd2b4ee9db493aeb54c8fafac818..dfaac5995c84c1f377023e6e62770c5548528a4c 100644 >> --- a/drivers/watchdog/qcom-wdt.c >> +++ b/drivers/watchdog/qcom-wdt.c >> @@ -181,6 +181,12 @@ static const struct qcom_wdt_match_data match_data_apcs_tmr = { >> .max_tick_count = 0x10000000U, >> }; >> >> +static const struct qcom_wdt_match_data match_data_ipq5424 = { >> + .offset = reg_offset_data_kpss, >> + .pretimeout = true, >> + .max_tick_count = 0xFFFFFU, >> +}; >> + >> static const struct qcom_wdt_match_data match_data_kpss = { >> .offset = reg_offset_data_kpss, >> .pretimeout = true, >> @@ -322,6 +328,7 @@ static const struct dev_pm_ops qcom_wdt_pm_ops = { >> }; >> >> static const struct of_device_id qcom_wdt_of_table[] = { >> + { .compatible = "qcom,apss-wdt-ipq5424", .data = &match_data_ipq5424 }, > Shouldn't it be qcom,ipq5424-apss-wdt ? Currently, the compatible string is "qcom,apss-wdt-ipq5424". So used as it is. > >> { .compatible = "qcom,kpss-timer", .data = &match_data_apcs_tmr }, >> { .compatible = "qcom,scss-timer", .data = &match_data_apcs_tmr }, >> { .compatible = "qcom,kpss-wdt", .data = &match_data_kpss }, >> >> -- >> 2.34.1 >>