* [PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is enabled
@ 2017-02-28 18:31 Randy Dunlap
2017-02-28 18:43 ` Guenter Roeck
2017-03-01 10:49 ` Charles Keepax
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2017-02-28 18:31 UTC (permalink / raw)
To: linux-watchdog, LKML; +Cc: Wim Van Sebroeck, Guenter Roeck, Mark Brown, patches
From: Randy Dunlap <rdunlap@infradead.org>
Fix kconfig dependencies when COMPILE_TEST is enabled so that
interdependent module dependencies are configured as needed.
Fixes build when WM831X_WATCHDOG=m and COMPILE_TEST=y.
No other WM831X drivers are enabled.
The problem is in mixing tristate and boolean dependencies.
ERROR: "wm831x_reg_write" [drivers/watchdog/wm831x_wdt.ko] undefined!
ERROR: "wm831x_reg_read" [drivers/watchdog/wm831x_wdt.ko] undefined!
ERROR: "wm831x_reg_unlock" [drivers/watchdog/wm831x_wdt.ko] undefined!
ERROR: "wm831x_reg_lock" [drivers/watchdog/wm831x_wdt.ko] undefined!
ERROR: "wm831x_set_bits" [drivers/watchdog/wm831x_wdt.ko] undefined!
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: patches@opensource.wolfsonmicro.com
Cc: Mark Brown <broonie@kernel.org>
---
drivers/watchdog/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20170228.orig/drivers/watchdog/Kconfig
+++ linux-next-20170228/drivers/watchdog/Kconfig
@@ -176,7 +176,7 @@ config WDAT_WDT
config WM831X_WATCHDOG
tristate "WM831x watchdog"
- depends on MFD_WM831X || COMPILE_TEST
+ depends on MFD_WM831X || (MFD_WM831X=y && COMPILE_TEST)
select WATCHDOG_CORE
help
Support for the watchdog in the WM831x AudioPlus PMICs. When
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is enabled
2017-02-28 18:31 [PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is enabled Randy Dunlap
@ 2017-02-28 18:43 ` Guenter Roeck
2017-03-01 10:49 ` Charles Keepax
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2017-02-28 18:43 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-watchdog, LKML, Wim Van Sebroeck, Mark Brown, patches
On Tue, Feb 28, 2017 at 10:31:15AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kconfig dependencies when COMPILE_TEST is enabled so that
> interdependent module dependencies are configured as needed.
>
> Fixes build when WM831X_WATCHDOG=m and COMPILE_TEST=y.
> No other WM831X drivers are enabled.
> The problem is in mixing tristate and boolean dependencies.
>
> ERROR: "wm831x_reg_write" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_reg_read" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_reg_unlock" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_reg_lock" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_set_bits" [drivers/watchdog/wm831x_wdt.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: patches@opensource.wolfsonmicro.com
> Cc: Mark Brown <broonie@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20170228.orig/drivers/watchdog/Kconfig
> +++ linux-next-20170228/drivers/watchdog/Kconfig
> @@ -176,7 +176,7 @@ config WDAT_WDT
>
> config WM831X_WATCHDOG
> tristate "WM831x watchdog"
> - depends on MFD_WM831X || COMPILE_TEST
> + depends on MFD_WM831X || (MFD_WM831X=y && COMPILE_TEST)
> select WATCHDOG_CORE
> help
> Support for the watchdog in the WM831x AudioPlus PMICs. When
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is enabled
2017-02-28 18:31 [PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is enabled Randy Dunlap
2017-02-28 18:43 ` Guenter Roeck
@ 2017-03-01 10:49 ` Charles Keepax
1 sibling, 0 replies; 3+ messages in thread
From: Charles Keepax @ 2017-03-01 10:49 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-watchdog, LKML, Wim Van Sebroeck, Guenter Roeck, Mark Brown,
patches
On Tue, Feb 28, 2017 at 10:31:15AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kconfig dependencies when COMPILE_TEST is enabled so that
> interdependent module dependencies are configured as needed.
>
> Fixes build when WM831X_WATCHDOG=m and COMPILE_TEST=y.
> No other WM831X drivers are enabled.
> The problem is in mixing tristate and boolean dependencies.
>
> ERROR: "wm831x_reg_write" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_reg_read" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_reg_unlock" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_reg_lock" [drivers/watchdog/wm831x_wdt.ko] undefined!
> ERROR: "wm831x_set_bits" [drivers/watchdog/wm831x_wdt.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: patches@opensource.wolfsonmicro.com
> Cc: Mark Brown <broonie@kernel.org>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-01 11:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-28 18:31 [PATCH -next] watchdog/wm831x: fix build when COMPILE_TEST is enabled Randy Dunlap
2017-02-28 18:43 ` Guenter Roeck
2017-03-01 10:49 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).