From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0C0ACA9EAE for ; Tue, 29 Oct 2019 17:58:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74A032086A for ; Tue, 29 Oct 2019 17:58:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726683AbfJ2R6a (ORCPT ); Tue, 29 Oct 2019 13:58:30 -0400 Received: from mailfilter04-out31.webhostingserver.nl ([141.138.168.145]:58265 "EHLO mailfilter04-out31.webhostingserver.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726635AbfJ2R6a (ORCPT ); Tue, 29 Oct 2019 13:58:30 -0400 X-Greylist: delayed 964 seconds by postgrey-1.27 at vger.kernel.org; Tue, 29 Oct 2019 13:58:28 EDT X-Halon-ID: 75933a1d-fa73-11e9-9119-001a4a4cb95f Received: from s198.webhostingserver.nl (unknown [195.211.72.171]) by mailfilter04.webhostingserver.nl (Halon) with ESMTPSA id 75933a1d-fa73-11e9-9119-001a4a4cb95f; Tue, 29 Oct 2019 18:42:21 +0100 (CET) Received: from cust-178-250-146-69.breedbanddelft.nl ([178.250.146.69] helo=[10.8.0.6]) by s198.webhostingserver.nl with esmtpa (Exim 4.92.3) (envelope-from ) id 1iPVVd-00BRay-3I; Tue, 29 Oct 2019 18:42:21 +0100 Subject: Re: [PATCH v1] watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support To: Guenter Roeck , Andy Shevchenko , Razvan Becheriu , linux-watchdog@vger.kernel.org, Wim Van Sebroeck References: <20190924143116.69823-1-andriy.shevchenko@linux.intel.com> <643ee5fc-a682-38bc-b92c-aee47913152e@roeck-us.net> From: Ferry Toth Message-ID: <980eb3ec-ab3e-5aa6-e4ae-4cbecf29f778@gmail.com> Date: Tue, 29 Oct 2019 18:42:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <643ee5fc-a682-38bc-b92c-aee47913152e@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SendingUser: hidden X-SendingServer: hidden X-Antivirus-Scanner: Clean mail though you should still use an Antivirus X-Authenticated-Id: hidden X-SendingUser: hidden X-SendingServer: hidden Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Op 30-09-2019 om 15:15 schreef Guenter Roeck: > On 9/24/19 7:31 AM, Andy Shevchenko wrote: >> Normally, the watchdog is disabled when /dev/watchdog is closed, but if >> CONFIG_WATCHDOG_NOWAYOUT is defined, then it means that the watchdog >> should >> remain enabled. So we should keep it enabled if CONFIG_WATCHDOG_NOWAYOUT >> is defined. >> >> Reported-by: Razvan Becheriu >> Cc: Ferry Toth >> Signed-off-by: Andy Shevchenko > > Reviewed-by: Guenter Roeck Any chance of this going in v5.4? >> --- >>   drivers/watchdog/intel-mid_wdt.c | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/drivers/watchdog/intel-mid_wdt.c >> b/drivers/watchdog/intel-mid_wdt.c >> index 2cdbd37c700c..470213abfd3d 100644 >> --- a/drivers/watchdog/intel-mid_wdt.c >> +++ b/drivers/watchdog/intel-mid_wdt.c >> @@ -134,6 +134,7 @@ static int mid_wdt_probe(struct platform_device >> *pdev) >>       wdt_dev->timeout = MID_WDT_DEFAULT_TIMEOUT; >>       wdt_dev->parent = dev; >> +    watchdog_set_nowayout(wdt_dev, WATCHDOG_NOWAYOUT); >>       watchdog_set_drvdata(wdt_dev, dev); >>       ret = devm_request_irq(dev, pdata->irq, mid_wdt_irq, >> >