From: Linus Walleij <linus.walleij@linaro.org>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: William Breathitt Gray <vilhelm.gray@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-iio@vger.kernel.org,
LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] gpio: Change ISA_BUS_API dependency to selection
Date: Fri, 23 Feb 2018 15:09:45 +0100 [thread overview]
Message-ID: <CACRpkdYmUrVAnZLJtxEdp__W8j1kFVPAhVDYr1Rb_1DczwzS+Q@mail.gmail.com> (raw)
In-Reply-To: <ec0c1668-dc0d-cd44-1c87-b1d71215f477@maciej.szmigiero.name>
On Fri, Feb 23, 2018 at 2:50 PM, Maciej S. Szmigiero
<mail@maciej.szmigiero.name> wrote:
> On 22.02.2018 21:44, Maciej S. Szmigiero wrote:
>> Note that gpio-winbond (CONFIG_GPIO_WINBOND) driver was originally
>> merged using ISA_BUS_API selection as done for other ISA bus gpio drivers
>> by this patch, then temporary switched to the previous ("depends on")
>> style by commit 92a8046c9d952a to fix a circular Kconfig dependency.
>> So now this commit (92...) should be reverted to make gpio-winbond
>> driver Kconfig dependency / selection consistent with the remaining ISA
>> bus gpio drivers.
>>
>> Unfortunately, I can't test the reversion myself because it looks like
>> Linus didn't push his trees yet to git.kernel.org after applying this
>> series (or I am not looking at the right place - linusw/linux-gpio.git?).
>
> It looks like the series has been pushed to git.kernel.org now.
> I have tested the reversion of commit 92a8046c9d952a and can confirm
> that the ISA_BUS_API dependency / selection for gpio-winbond works
> then as intended (in a way that is consistent with other ISA bus gpio
> drivers).
>
> @Linus:
> Will you revert that commit or should I submit a patch that does it?
Oh send me a patch, that's easiest.
Yours,
Linus Walleij
next prev parent reply other threads:[~2018-02-23 14:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 20:13 [PATCH v2 0/5] Change ISA_BUS_API dependency to selection William Breathitt Gray
2017-12-29 20:13 ` [PATCH v2 1/5] iio: " William Breathitt Gray
2018-01-01 9:55 ` Jonathan Cameron
2018-02-22 15:14 ` Linus Walleij
2017-12-29 20:13 ` [PATCH v2 2/5] watchdog: " William Breathitt Gray
2018-02-22 15:15 ` Linus Walleij
2017-12-29 20:13 ` [PATCH v2 3/5] gpio: " William Breathitt Gray
2018-02-22 15:16 ` Linus Walleij
2018-02-22 20:30 ` William Breathitt Gray
2018-02-22 20:44 ` Maciej S. Szmigiero
2018-02-23 13:50 ` Maciej S. Szmigiero
2018-02-23 14:09 ` Linus Walleij [this message]
2017-12-29 20:14 ` [PATCH v2 4/5] isa: Remove ISA_BUS_API selection for ISA_BUS William Breathitt Gray
2018-02-22 15:18 ` Linus Walleij
2017-12-29 20:14 ` [PATCH v2 5/5] pc104: Add EXPERT dependency for PC104 Kconfig option William Breathitt Gray
2018-02-22 15:20 ` Linus Walleij
2018-02-22 20:45 ` William Breathitt Gray
2018-01-02 9:29 ` [PATCH v2 0/5] Change ISA_BUS_API dependency to selection Linus Walleij
2018-01-31 2:22 ` William Breathitt Gray
2018-02-19 14:47 ` Maciej S. Szmigiero
2018-02-22 15:13 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYmUrVAnZLJtxEdp__W8j1kFVPAhVDYr1Rb_1DczwzS+Q@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mail@maciej.szmigiero.name \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).