From: Sachin Kamat <sachin.kamat@linaro.org>
To: Leela Krishna Amudala <l.krishna@samsung.com>
Cc: linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Wim Van Sebroeck <wim@iguana.be>,
Kukjin Kim <kgene.kim@samsung.com>,
devicetree@vger.kernel.org, Tomasz Figa <t.figa@samsung.com>,
Douglas Anderson <dianders@chromium.org>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH V2 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses
Date: Fri, 27 Sep 2013 22:23:23 +0530 [thread overview]
Message-ID: <CAK9yfHxBnj39w=YrBw-PyT-Anpprx8Zn4d0O6BPp__qNGH4Xhg@mail.gmail.com> (raw)
In-Reply-To: <1380276986-24131-4-git-send-email-l.krishna@samsung.com>
On 27 September 2013 15:46, Leela Krishna Amudala <l.krishna@samsung.com> wrote:
> This patch parses the watchdog node to read pmu wdt sys registers addresses
> and do mask/unmask enable/disable of WDT in probe and s2r scenarios.
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
> .../devicetree/bindings/watchdog/samsung-wdt.txt | 24 ++++-
> drivers/watchdog/s3c2410_wdt.c | 94 ++++++++++++++++++--
> 2 files changed, 108 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt b/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt
> index 2aa486c..f78b802 100644
> --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt
> @@ -5,10 +5,30 @@ after a preset amount of time during which the WDT reset event has not
> occurred.
>
> Required properties:
> -- compatible : should be "samsung,s3c2410-wdt"
> +- compatible : should be "samsung,s3c2410-wdt" or "samsung,s3c5250-wdt"
It would also be helpful to mention the SoCs along with the compatibles strings.
> - reg : base physical address of the controller and length of memory mapped
> - region.
> + region and additional (addresses and length of memory mapped regions
> + of) PMU registers for masking/unmasking WDT only in case of Exynos5250 and 5420.
> - interrupts : interrupt number to the cpu.
> +- reset-mask-bit: bit number in the PMU registers to program mask/unmask WDT (required only
> + in case of Exynos5250 and 5420).
>
> Optional properties:
> - timeout-sec : contains the watchdog timeout in seconds.
> +
> +Examples:
> +
> +watchdog {
watchdog@101D0000
> + compatible = "samsung,s3c2410-wdt";
> + reg = <0x101D0000 0x100>;
> + interrupts = <0 42 0>;
> + status = "disabled";
> +};
> +
> +watchdog {
ditto
> + compatible = "samsung,s3c5250-wdt";
> + reg = <0x101D0000 0x100>, <0x10040408 0x4>, <0x1004040c 0x4>;
--
With warm regards,
Sachin
next prev parent reply other threads:[~2013-09-27 16:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 10:16 [PATCH V2 0/4] Add watchdog DT nodes and parse it to read PMU registers addresses Leela Krishna Amudala
2013-09-27 10:16 ` [PATCH V2 1/4] ARM: dts: Fix the watchdog DT node name for Exynos5 Leela Krishna Amudala
2013-09-27 21:04 ` Doug Anderson
2013-09-27 10:16 ` [PATCH V2 2/4] ARM: dts: add watchdog device tree node for exynos5420 Leela Krishna Amudala
2013-09-27 21:07 ` Doug Anderson
2013-09-27 10:16 ` [PATCH V2 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses Leela Krishna Amudala
2013-09-27 16:53 ` Sachin Kamat [this message]
2013-09-27 10:16 ` [PATCH V2 4/4] ARM: dts: exynos: add PMU registers addresses and mask bit to watchdog node Leela Krishna Amudala
2013-09-27 16:47 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK9yfHxBnj39w=YrBw-PyT-Anpprx8Zn4d0O6BPp__qNGH4Xhg@mail.gmail.com' \
--to=sachin.kamat@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=l.krishna@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=t.figa@samsung.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).