From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Philipp Zabel <p.zabel@pengutronix.de>,
Linux Watchdog Mailing List <linux-watchdog@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v5 4/7] watchdog: rzg2l_wdt: Fix reset control imbalance
Date: Tue, 1 Mar 2022 12:20:44 +0100 [thread overview]
Message-ID: <CAMuHMdWan4gFG3Hi01C9+2q=sntYuxbMYtaJOAGo0DWFRt2HPg@mail.gmail.com> (raw)
In-Reply-To: <20220225175320.11041-5-biju.das.jz@bp.renesas.com>
On Fri, Feb 25, 2022 at 6:53 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Both rzg2l_wdt_probe() and rzg2l_wdt_start() calls reset_control_
> deassert() which results in a reset control imbalance.
>
> This patch fixes reset control imbalance by removing reset_control_
> deassert() from rzg2l_wdt_start() and replaces reset_control_assert with
> reset_control_reset in rzg2l_wdt_stop() as watchdog module can be stopped
> only by a module reset. This change will allow us to restart WDT after
> stop() by configuring WDT timeout and enable registers.
>
> Fixes: 2cbc5cd0b55fa2 ("watchdog: Add Watchdog Timer driver for RZ/G2L")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2022-03-01 11:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 17:53 [PATCH v5 0/7] RZG2L_WDT Fixes and Improvements Biju Das
2022-02-25 17:53 ` [PATCH v5 1/7] watchdog: rzg2l_wdt: Fix 32bit overflow issue Biju Das
2022-02-25 17:53 ` [PATCH v5 2/7] watchdog: rzg2l_wdt: Fix Runtime PM usage Biju Das
2022-02-25 20:17 ` Guenter Roeck
2022-02-25 17:53 ` [PATCH v5 3/7] watchdog: rzg2l_wdt: Fix 'BUG: Invalid wait context' Biju Das
2022-02-25 20:18 ` Guenter Roeck
2022-02-25 17:53 ` [PATCH v5 4/7] watchdog: rzg2l_wdt: Fix reset control imbalance Biju Das
2022-03-01 11:20 ` Geert Uytterhoeven [this message]
2022-03-09 23:08 ` Guenter Roeck
2022-02-25 17:53 ` [PATCH v5 5/7] watchdog: rzg2l_wdt: Add error check for reset_control_deassert Biju Das
2022-02-26 9:15 ` Sergei Shtylyov
2022-02-28 14:36 ` Biju Das
2022-03-01 11:21 ` Geert Uytterhoeven
2022-03-09 23:09 ` Guenter Roeck
2022-02-25 17:53 ` [PATCH v5 6/7] watchdog: rzg2l_wdt: Use force reset for WDT reset Biju Das
2022-02-25 20:18 ` Guenter Roeck
2022-02-25 17:53 ` [PATCH v5 7/7] watchdog: rzg2l_wdt: Add set_timeout callback Biju Das
2022-02-25 20:18 ` Guenter Roeck
2022-03-07 8:52 ` [PATCH v5 0/7] RZG2L_WDT Fixes and Improvements Biju Das
2022-03-09 23:42 ` Guenter Roeck
2022-03-10 6:53 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWan4gFG3Hi01C9+2q=sntYuxbMYtaJOAGo0DWFRt2HPg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).