From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.246.85.4 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792482783; b=xtKnyQHUsOd8RjEE98q6XYjT+J+f1SFhDWA0y/zmJ5aSb8vs2hqmNInOEe9whm0EBbnQ OrNZRLkE5rvXWCcRcekDJUJog4aR6O8sOE2tt9oEV8fgBC7SO+qI5fjZBVQTzjJuq/BP2 5wKd9konfqHQo3aZ8hR5yGoEcmh1iB/Grm7250lpLureStpf42Gbf7Sjm6zLrCtFdN/tu +YwRoNNfxS2WwwELNgNRMBwwJn24gCWGCUO2b88ERF9g0fqSfmYp3N/uSRHVFSy++L8WD oKYMugDsysk6vs1kTGGi8WS7UFmqFlh7W2F+9O+W2zS11uCY886aacZtTUUuWuSVNmQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792482783; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:Mime-Version: Content-Transfer-Encoding:Content-Type:Date:Message-Id:Subject:From: To:Cc:X-Mailer:References:In-Reply-To:X-Last-TLS-Session-Version; bh=hi+RizexM700lJm+zJb+vjtDDdoQ9eNhKLCKMXQF8Cc=; b=VvAXkQIF1GK9DwxzVehr0lnQYZYZwGQnBn6S50S7T4qCNmALaY/4VuzpWx2R49PsDqvH XUyays2+n4Oc8h1E6CaGHHV65d7q1NNgjS/S8uoqTW9wiD2SEM2uQLU+tgUZXAnTPMOr1 iuLf7TvAybbykjbd5tbe+95fGIqq0Lnbfjs4SGKGsCoeJwB+KYOjPqDx3Ay1FEiFIV8oA pcBrJyhKzwlW5yptSilc9/k5aHnGPsB0wiooaoLsvYIrEH6r+rCA0OX+VJgzk4aDJOq7C oovbRYGh+FcVRNIMEcd7XG0h+y43a+5RJtxhiy8iBOoMfLbY6YnIZZIQI+4/LugBvTQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=y9eroWaR; arc=none smtp.remote-ip=185.246.85.4 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ED3C606A31C for ; Tue, 20 Oct 2026 07:53:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5ED3C606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=y9eroWaR Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 7A5DD4E4128D; Tue, 20 Oct 2026 07:52:59 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 3E4D460393; Tue, 20 Oct 2026 07:52:59 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 351CF10328D8B; Tue, 20 Oct 2026 09:52:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1792482778; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=hi+RizexM700lJm+zJb+vjtDDdoQ9eNhKLCKMXQF8Cc=; b=y9eroWaRPITyTjrHPUIpCtTPYTC79pAmN2AmgzyvBdS1kRnW21+VrVlTLK8BMm4l8okMu+ xH3nRyzR2BGLvPQdz4I2NdNL+ZMkfigJpysxQdhxErANk56ghzvZkVO75XuBb3apI0Z1VO tzIdlH4OFyB+0Ik3L3qRGe87m/SKpahFF/iyoI/XFakxkaAFwkv2ODQ7PvDOz9IRlcs/OI isk6wZjjj4v+LR2g5xlxVrY3ZDzVtGtAiXrFPpIrgI221e7u/2oA4F3x7wds0epUUUFfhN 9yLeEC16MIIGBbTn2hc1/++Q8g8vvayyUDSXYj00hUUASHpBMzEXmU0P+E8Hbw== X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 20 Oct 2026 09:52:54 +0200 Message-Id: Subject: Re: [PATCH v4 1/6] watchdog: w83627hf_wdt: Fix watchdog identity truncation From: "Paul Louvel" To: "Tzung-Bi Shih" , "Paul Louvel" Cc: "Wim Van Sebroeck" , "Guenter Roeck" , , , "Thomas Petazzoni" , , "kernel test robot" X-Mailer: aerc 0.22.0-0-gc2f86b7abde3 References: <20261013-w83627hf_wdt-improvements-v4-0-b6f6b60a9566@bootlin.com> <20261013-w83627hf_wdt-improvements-v4-1-b6f6b60a9566@bootlin.com> In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 On Mon Oct 19, 2026 at 5:22 PM CEST, Tzung-Bi Shih wrote: > On Tue, Oct 13, 2026 at 03:58:45PM +0200, Paul Louvel wrote: >> The identity field in struct watchdog_info is only 32 bytes in size, but >> the identity could be at most 33 bytes in this driver, resulting in >> truncation. >> Remove the "Watchdog" suffix, as this is implied that the device is a >> watchdog if a user request his identity. >>=20 >> Cc: >> Fixes: 3d6757a640f8 ("watchdog: w83627hf_wdt: Report the probed chip nam= e via WDIOC_GETSUPPORT") >> Reported-by: kernel test robot >> Closes: https://lore.kernel.org/oe-kbuild-all/202610080027.3OsJDwfo-lkp@= intel.com/ > > The patch doesn't really fix anything. The longest string in `chip_name` > with the " Watchdog" suffix is still under 32 bytes. Indeed, max is 21. No idea why it got reported in the first place also. Best regards, --=20 Paul Louvel, Bootlin Embedded Linux and Kernel engineering https://bootlin.com