From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.171.202.116 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792513702; b=r1gieQ7a5B5fjlU3rpFNCAAM+NRdZHjKc/1Mby+6BkFxUlAg34mOdIGh2FpbJmTErbxQ WrXSYjcwlfhJFbIgrFkU6N+2xZgCEmBbt7j0Xw+K8LY1rgjni67btTYXeLeDdzwxpYq1E mypFWUAMj1SvQH/lZpoyxVHUXka6J/p0UrdqOS8puNQOuMX9RNY+qG/BqnCIeTL8kdCYa on5e9LsKz85vDMlzyaOK/DDRaSg1WckH1iS15p6Ei9ggvbLFnf0kcKOYZz5FgilJeVeka Crpgu0TRkA2vZUdMRc9SwIfQkm2Ygax//KKaGI7l1g31/PTHWiMitIvTMQdcsoutWOw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792513702; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:Mime-Version: Content-Transfer-Encoding:Content-Type:Date:Message-Id:Cc:Subject: From:To:X-Mailer:References:In-Reply-To:X-Last-TLS-Session-Version; bh=cFCna6SUD0Wp3UCxIkX+ZlOhx4JI52T+zh+uPphPJ/4=; b=iR0u721Mg1oizlHKqUJH++zaUgmSE/oHcbN2lwx+RZ06sAUSPUo7wZHQeFFsqpnBSNvl qKuGvYUOMC8j2EShjaYpSfgs9QuWAIDrwy3nHKTEy6Dz2WVTB5Z721VMGDGOXF3r5cwYR SyYwX+7Gy/gTpvO1OmiiJYVjI44V4qTNzP3mzGPNCJ7j2Qmh42nzUVYwcS/OxqOxQU/de 14d3V2ykT7TrabirOsJqkcVEYzccXK7MDb8neeHjy9h3WuYU1v5jyErvdw27EJqy396Ln Kh7sFv1M4O6vWghLXVDbatFf0WKJc6j/frhI+/dr7gbf8GK4A/vgh558ikHXfsg5aNA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=uraJsGDJ; arc=none smtp.remote-ip=185.171.202.116 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B595606A31E for ; Tue, 20 Oct 2026 16:28:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4B595606A31E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=uraJsGDJ Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id C621EC5CD64 for ; Tue, 20 Oct 2026 16:29:16 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 394E660393; Tue, 20 Oct 2026 16:28:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C6B20103289A8; Tue, 20 Oct 2026 18:28:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1792513693; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=cFCna6SUD0Wp3UCxIkX+ZlOhx4JI52T+zh+uPphPJ/4=; b=uraJsGDJfBDuTtyvTlJGHCB/EkKY5UwwXFAsSloHRoPJE3RW6Sfqa5/WUjXoRFwij9SJyl 4tUrbvb1PMfHQYNSJy1p59wBH1GKnPi9nDTLewcnBqhj7IHcIey4aZBiLXznJCdgNoDwZG KdrPxPaYP6cgbENhlhw2Dk39r9mMtKsqZDJG7A6A2somMYjwJhW3dfAUJWievmPaqSLrFx d/OZpCYPjZOUSzQ1um+9Qvte1venYnabYEXUJeuIRBLZeHFSpHxCIp1FS6gCISb3dZ0jnV c6h2PjGJPAJUpcHG8uEK/v8h1az5+DcsPQZePcp8ykeCw8YXIu6QRYIJfsIVmg== X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 20 Oct 2026 18:28:11 +0200 Message-Id: Cc: "Wim Van Sebroeck" , "Guenter Roeck" , , , "Thomas Petazzoni" Subject: Re: [PATCH v5 5/5] watchdog: w83627hf_wdt: Add minute mode counting From: "Paul Louvel" To: "Tzung-Bi Shih" , "Paul Louvel" X-Mailer: aerc 0.22.0-0-gc2f86b7abde3 References: <20261020-w83627hf_wdt-improvements-v5-0-90b226684fc7@bootlin.com> <20261020-w83627hf_wdt-improvements-v5-5-90b226684fc7@bootlin.com> In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 On Tue Oct 20, 2026 at 4:08 PM CEST, Tzung-Bi Shih wrote: > On Tue, Oct 20, 2026 at 10:11:58AM +0200, Paul Louvel wrote: >> All of the chips supported by the driver can be set to minute mode, >> allowing timeout value up to 255 minutes. >> Add it to the driver. > > I didn't review the patch carefully as I was thinking about a fundamental > question: isn't 255 seconds already more than enough for a hardware > watchdog? Why does it need to support minute mode for timeouts larger th= an > that? > >> @@ -49,7 +50,8 @@ enum chips { w83627hf, w83627s, w83697hf, w83697ug, w8= 3637hf, w83627thf, >> static int timeout; /* in seconds */ >> module_param(timeout, int, 0); >> MODULE_PARM_DESC(timeout, >> - "Watchdog timeout in seconds. 1 <=3D timeout <=3D 255, default=3D" >> + "Watchdog timeout in seconds. 1 <=3D timeout <=3D " >> + __MODULE_STRING(WATCHDOG_MAX_TIMEOUT) ", default=3D" >> __MODULE_STRING(WATCHDOG_TIMEOUT) "."); > > The patch is obviously not based on the watchdog-next branch (see commit > b152ca999c5f ("watchdog: Replace __MODULE_STRING() with __stringify()")). Thanks. Indeed, the series was based on v7.3-rc7 tag. --=20 Paul Louvel, Bootlin Embedded Linux and Kernel engineering https://bootlin.com