From: Andy Shevchenko <andy@kernel.org>
To: "Marek Behún" <kabel@kernel.org>
Cc: Gregory CLEMENT <gregory.clement@bootlin.com>,
Arnd Bergmann <arnd@arndb.de>,
soc@kernel.org, arm@kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v2 2/7] platform: cznic: Add preliminary support for Turris Omnia MCU
Date: Wed, 20 Sep 2023 17:47:12 +0300 [thread overview]
Message-ID: <ZQsF8FWwfAuT26yE@smile.fi.intel.com> (raw)
In-Reply-To: <20230920161953.6d952392@dellmb>
On Wed, Sep 20, 2023 at 04:19:53PM +0200, Marek Behún wrote:
> On Tue, 19 Sep 2023 21:27:04 +0300
> Andy Shevchenko <andy@kernel.org> wrote:
> > On Tue, Sep 19, 2023 at 05:16:38PM +0200, Marek Behún wrote:
> > > On Tue, 19 Sep 2023 15:29:08 +0300
> > > Andy Shevchenko <andy@kernel.org> wrote:
> > > > On Tue, Sep 19, 2023 at 12:38:10PM +0200, Marek Behún wrote:
...
> > > > > + if (likely(ret == ARRAY_SIZE(msgs)))
> > > >
> > > > Why likely()? Please, justify.
> > >
> > > Becuase it is unlikely the I2C transaction will fail. In most cases, it
> > > does not.
> >
> > Yes, but why likely() is needed? So, i.o.w. what's the benefit in _this_ case?
>
> Compiler optimization (one branch avoided). But I guess this isn't a
> hot path, since I2C is insanely slow anyway. OK, I shall remove the
> likely() usage.
Have you seen the difference in the generated code, btw?
I don't think it will get you one independently on the hot/slow
path.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-20 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230919103815.16818-1-kabel@kernel.org>
[not found] ` <20230919103815.16818-3-kabel@kernel.org>
2023-09-19 12:29 ` [PATCH v2 2/7] platform: cznic: Add preliminary support for Turris Omnia MCU Andy Shevchenko
[not found] ` <20230919171638.19bc1619@dellmb>
2023-09-19 18:27 ` Andy Shevchenko
[not found] ` <20230920161953.6d952392@dellmb>
2023-09-20 14:47 ` Andy Shevchenko [this message]
[not found] ` <20230919103815.16818-6-kabel@kernel.org>
2023-09-19 13:50 ` [PATCH v2 5/7] platform: cznic: turris-omnia-mcu: Add support for MCU watchdog Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQsF8FWwfAuT26yE@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=gregory.clement@bootlin.com \
--cc=kabel@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=soc@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox