Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: "René van Dorst" <opensource@vdorst.com>,
	linux-watchdog@vger.kernel.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] watchdog: mt7621: Fix compiler error, missing include
Date: Tue, 15 Jan 2019 16:16:06 +0100	[thread overview]
Message-ID: <a8b870f2-a50d-144e-cdca-b8a95d48846b@gmail.com> (raw)
In-Reply-To: <20190114211719.11461-1-opensource@vdorst.com>



On 14/01/2019 22:17, René van Dorst wrote:
> drivers/watchdog/mt7621_wdt.c:174:34: error: array type has incomplete element type 'struct of_device_id'
>  static const struct of_device_id mt7621_wdt_match[] = {
>                                   ^~~~~~~~~~~~~~~~
> drivers/watchdog/mt7621_wdt.c:175:4: error: field name not in record or union initializer
>   { .compatible = "mediatek,mt7621-wdt" },
>     ^
> drivers/watchdog/mt7621_wdt.c:175:4: note: (near initialization for 'mt7621_wdt_match')
> drivers/watchdog/mt7621_wdt.c:174:34: warning: 'mt7621_wdt_match' defined but not used [-Wunused-variable]
>  static const struct of_device_id mt7621_wdt_match[] = {
>                                   ^~~~~~~~~~~~~~~~
> 

Did this work in the past?
I suppose so. Could you provide a fixes tag for stable.

Thanks,
Matthias

> Signed-off-by: René van Dorst <opensource@vdorst.com>
> ---
>  drivers/watchdog/mt7621_wdt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/mt7621_wdt.c b/drivers/watchdog/mt7621_wdt.c
> index 5c4a764717c4..a3be7db9d76f 100644
> --- a/drivers/watchdog/mt7621_wdt.c
> +++ b/drivers/watchdog/mt7621_wdt.c
> @@ -16,6 +16,7 @@
>  #include <linux/kernel.h>
>  #include <linux/watchdog.h>
>  #include <linux/moduleparam.h>
> +#include <linux/of.h>
>  #include <linux/platform_device.h>
>  
>  #include <asm/mach-ralink/ralink_regs.h>
> 

       reply	other threads:[~2019-01-15 15:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190114211719.11461-1-opensource@vdorst.com>
2019-01-15 15:16 ` Matthias Brugger [this message]
2019-01-15 15:29   ` [PATCH] watchdog: mt7621: Fix compiler error, missing include René van Dorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8b870f2-a50d-144e-cdca-b8a95d48846b@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=opensource@vdorst.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox