Re: [PATCH 1/3] watchdog: qcom: update device tree bindings

[Thomas Pedersen <twp@codeaurora.org>]

On 2016-06-28 10:24, Mark Rutland wrote:
> On Tue, Jun 28, 2016 at 10:17:32AM -0700, Thomas Pedersen wrote:
>> On 2016-06-27 22:20, Guenter Roeck wrote:
>> >On 06/27/2016 04:26 PM, Thomas Pedersen wrote:
>> >>From: Matthew McClintock <mmcclint@codeaurora.org>
>> >>
>> >>Update the compatible string to align with driver
>> >>
>> >>CC: linux-watchdog@vger.kernel.org
>> >>Signed-off-by: Matthew McClintock <mmcclint@codeaurora.org>
>> >>---
>> >>  Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 5 ++---
>> >>  1 file changed, 2 insertions(+), 3 deletions(-)
>> >>
>> >>diff --git
>> >>a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>> >>b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>> >>index 4726924..60bb2f98 100644
>> >>--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>> >>+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>> >>@@ -4,9 +4,8 @@ Qualcomm Krait Processor Sub-system (KPSS) Watchdog
>> >>  Required properties :
>> >>  - compatible : shall contain only one of the following:
>> >>
>> >>-			"qcom,kpss-wdt-msm8960"
>> >>-			"qcom,kpss-wdt-apq8064"
>> >>-			"qcom,kpss-wdt-ipq8064"
>> >>+			"qcom,kpss-timer"
>> >>+			"qcom,scss-timer"
>> >>
>> >>  - reg : shall contain base register location and length
>> >>  - clocks : shall contain the input clock
>> >>
>> >
>> >Rob's earlier feedback to the same patch you had submitted in March:
>> >
>> >"Keep the SoC specific ones even if they are not used. The DTS should
>> >have both strings."
>> 
>> Why would we add the SoC specific compatible strings to the DTS if
>> they're not
>> even used?
> 
> Because they might be in future, and having them present in existing
> DTBs will make our lives easier. Otherwise, they cost very little.

Hm, ok.

-- 
thomas