* [PATCH v2 0/1] watchdog: Remove MODULE_ALIAS from menz69_wdt
@ 2026-01-08 13:33 Jose Javier Rodriguez Barbarin
2026-01-08 13:33 ` [PATCH v2 1/1] watchdog: menz069_wdt: drop unneeded MODULE_ALIAS Jose Javier Rodriguez Barbarin
2026-03-09 11:26 ` [PATCH v2 0/1] watchdog: Remove MODULE_ALIAS from menz69_wdt Jose Javier Rodriguez Barbarin
0 siblings, 2 replies; 3+ messages in thread
From: Jose Javier Rodriguez Barbarin @ 2026-01-08 13:33 UTC (permalink / raw)
To: jth, wim, linux
Cc: andriy.shevchenko, dev-jorge.sanjuangarcia, linux-watchdog,
linux-kernel, Jose Javier Rodriguez Barbarin
The first patches I sent for fixing the autoload problem encountered
on mcb device drivers were 2. The first [1] was focused on updating the
modpost process for letting kbuild to access to the data within
MODULE_DEVICE_TABLE and the second one [2] for removing the MODULE_ALIAS
on all mcb client drivers.
They were rejected and Andy suggested me to split the second patch
in a per-driver basis instead of sending all drivers' changes in a
single patch once the first patch was merged.
The first patch is already merged on Linus's Git repository for 6.19-rc4
commit 1f4ea4838b13 ("mcb: Add missing modpost build support")
So now I am sending this patch for removing MODULE_ALIASon all mcb client
drivers as it is no longer required. This cleanup is being sent to each
affected subsystem separately, as per the review suggestion to ease
the handling for maintainers.
[1] https://lore.kernel.org/all/20251127155452.42660-2-dev-josejavier.rodriguez@duagon.com/
[2] https://lore.kernel.org/all/20251127155452.42660-3-dev-josejavier.rodriguez@duagon.com/
changes in v2:
- Renane commit message
Jose Javier Rodriguez Barbarin (1):
watchdog: menz069_wdt: drop unneeded MODULE_ALIAS
drivers/watchdog/menz69_wdt.c | 1 -
1 file changed, 1 deletion(-)
--
2.52.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/1] watchdog: menz069_wdt: drop unneeded MODULE_ALIAS
2026-01-08 13:33 [PATCH v2 0/1] watchdog: Remove MODULE_ALIAS from menz69_wdt Jose Javier Rodriguez Barbarin
@ 2026-01-08 13:33 ` Jose Javier Rodriguez Barbarin
2026-03-09 11:26 ` [PATCH v2 0/1] watchdog: Remove MODULE_ALIAS from menz69_wdt Jose Javier Rodriguez Barbarin
1 sibling, 0 replies; 3+ messages in thread
From: Jose Javier Rodriguez Barbarin @ 2026-01-08 13:33 UTC (permalink / raw)
To: jth, wim, linux
Cc: andriy.shevchenko, dev-jorge.sanjuangarcia, linux-watchdog,
linux-kernel, Jose Javier Rodriguez Barbarin
Since commit 1f4ea4838b13 ("mcb: Add missing modpost build support")
the MODULE_ALIAS() is redundant as the module alias is now
automatically generated from the MODULE_DEVICE_TABLE().
Remove the explicit alias.
No functional change intended.
Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
---
drivers/watchdog/menz69_wdt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/watchdog/menz69_wdt.c b/drivers/watchdog/menz69_wdt.c
index 6e5e4e5c0b56..3fe23451135d 100644
--- a/drivers/watchdog/menz69_wdt.c
+++ b/drivers/watchdog/menz69_wdt.c
@@ -163,5 +163,4 @@ module_mcb_driver(men_z069_driver);
MODULE_AUTHOR("Johannes Thumshirn <jth@kernel.org>");
MODULE_DESCRIPTION("Watchdog driver for the MEN z069 IP-Core");
MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("mcb:16z069");
MODULE_IMPORT_NS("MCB");
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 0/1] watchdog: Remove MODULE_ALIAS from menz69_wdt
2026-01-08 13:33 [PATCH v2 0/1] watchdog: Remove MODULE_ALIAS from menz69_wdt Jose Javier Rodriguez Barbarin
2026-01-08 13:33 ` [PATCH v2 1/1] watchdog: menz069_wdt: drop unneeded MODULE_ALIAS Jose Javier Rodriguez Barbarin
@ 2026-03-09 11:26 ` Jose Javier Rodriguez Barbarin
1 sibling, 0 replies; 3+ messages in thread
From: Jose Javier Rodriguez Barbarin @ 2026-03-09 11:26 UTC (permalink / raw)
To: jth, wim, linux
Cc: andriy.shevchenko, dev-jorge.sanjuangarcia, linux-watchdog,
linux-kernel
On Thu, Jan 08, 2026 at 02:33:31PM +0100, Jose Javier Rodriguez Barbarin wrote:
> The first patches I sent for fixing the autoload problem encountered
> on mcb device drivers were 2. The first [1] was focused on updating the
> modpost process for letting kbuild to access to the data within
> MODULE_DEVICE_TABLE and the second one [2] for removing the MODULE_ALIAS
> on all mcb client drivers.
>
> They were rejected and Andy suggested me to split the second patch
> in a per-driver basis instead of sending all drivers' changes in a
> single patch once the first patch was merged.
>
> The first patch is already merged on Linus's Git repository for 6.19-rc4
>
> commit 1f4ea4838b13 ("mcb: Add missing modpost build support")
>
> So now I am sending this patch for removing MODULE_ALIASon all mcb client
> drivers as it is no longer required. This cleanup is being sent to each
> affected subsystem separately, as per the review suggestion to ease
> the handling for maintainers.
>
> [1] https://lore.kernel.org/all/20251127155452.42660-2-dev-josejavier.rodriguez@duagon.com/
> [2] https://lore.kernel.org/all/20251127155452.42660-3-dev-josejavier.rodriguez@duagon.com/
>
> changes in v2:
> - Renane commit message
>
> Jose Javier Rodriguez Barbarin (1):
> watchdog: menz069_wdt: drop unneeded MODULE_ALIAS
>
> drivers/watchdog/menz69_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --
> 2.52.0
Dear all,
I sent this patch series a few months ago. I thought It was already applied
but after synchronizing my local I came across that this patch is missing.
Could you give me some feedback?
Thank you so much.
Javier R.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-09 11:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-08 13:33 [PATCH v2 0/1] watchdog: Remove MODULE_ALIAS from menz69_wdt Jose Javier Rodriguez Barbarin
2026-01-08 13:33 ` [PATCH v2 1/1] watchdog: menz069_wdt: drop unneeded MODULE_ALIAS Jose Javier Rodriguez Barbarin
2026-03-09 11:26 ` [PATCH v2 0/1] watchdog: Remove MODULE_ALIAS from menz69_wdt Jose Javier Rodriguez Barbarin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox