From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: linux-watchdog@vger.kernel.org
Subject: [PATCH] watchdog: Remove misleading word "legacy" for /dev/watchdog
Date: Sun, 16 Oct 2016 06:49:20 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.20.1610160645550.19356@localhost.localdomain> (raw)
The word "legacy" should not be used for the special file
/dev/watchdog, as that file is still essential for watchdog
operations.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
i expressed my reservations about use of the word "legacy" here:
https://lists.kernelnewbies.org/pipermail/kernelnewbies/2016-October/017054.html
diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
index 32930a0..0cc5ab8 100644
--- a/drivers/watchdog/watchdog_dev.c
+++ b/drivers/watchdog/watchdog_dev.c
@@ -891,7 +891,7 @@ static struct miscdevice watchdog_miscdev = {
* @wdd: watchdog device
* @devno: character device number
*
- * Register a watchdog character device including handling the legacy
+ * Register a watchdog character device including handling the
* /dev/watchdog node. /dev/watchdog is actually a miscdevice and
* thus we set it up like that.
*/
@@ -968,7 +968,7 @@ static int watchdog_cdev_register(struct watchdog_device *wdd, dev_t devno)
* watchdog_cdev_unregister: unregister watchdog character device
* @watchdog: watchdog device
*
- * Unregister watchdog character device and if needed the legacy
+ * Unregister watchdog character device and if needed the
* /dev/watchdog device.
*/
@@ -1002,7 +1002,7 @@ static struct class watchdog_class = {
* watchdog_dev_register: register a watchdog device
* @wdd: watchdog device
*
- * Register a watchdog device including handling the legacy
+ * Register a watchdog device including handling the
* /dev/watchdog node. /dev/watchdog is actually a miscdevice and
* thus we set it up like that.
*/
@@ -1040,7 +1040,7 @@ int watchdog_dev_register(struct watchdog_device *wdd)
* watchdog_dev_unregister: unregister a watchdog device
* @watchdog: watchdog device
*
- * Unregister watchdog device and if needed the legacy
+ * Unregister watchdog device and if needed the
* /dev/watchdog device.
*/
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
next reply other threads:[~2016-10-16 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-16 10:49 Robert P. J. Day [this message]
2016-10-16 15:38 ` [PATCH] watchdog: Remove misleading word "legacy" for /dev/watchdog Guenter Roeck
2016-10-16 15:41 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1610160645550.19356@localhost.localdomain \
--to=rpjday@crashcourse.ca \
--cc=linux-watchdog@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox