Re: [PATCH v5 3/4] ARM: dts: mediatek: mt8127: Add watchdog support

[Zakariya Hadrami <zkh@mailbox.org>]

On Thu, Sep 10, 2026 at 01:36:04PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The watchdog node is disabled by default in the SoC .dtsi, which is a device tree anti-pattern for internal IPs without board-specific dependencies.
> --
> 
> commit 00ce16ebfa121cfaa7d2f6798bebf7e7aabf4c90
> Author: Zakariya Hadrami <zkh@mailbox.org>
> 
> ARM: dts: mediatek: mt8127: Add watchdog support
> 
> This commit adds the watchdog node for MT8127 and explicitly disables it by
> default in the SoC dtsi.
> 
> > diff --git a/arch/arm/boot/dts/mediatek/mt8127.dtsi b/arch/arm/boot/dts/mediatek/mt8127.dtsi
> > index bd61ec7e70c0c..9bdf55d2da479 100644
> > --- a/arch/arm/boot/dts/mediatek/mt8127.dtsi
> > +++ b/arch/arm/boot/dts/mediatek/mt8127.dtsi
> > @@ -99,6 +99,13 @@ soc {
> >  		compatible = "simple-bus";
> >  		ranges;
> >  
> > +		watchdog: watchdog@10007000 {
> > +			compatible = "mediatek,mt8127-wdt", "mediatek,mt6589-wdt";
> > +			reg = <0 0x10007000 0 0x100>;
> > +			interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_LOW>;
> > +			status = "disabled";
> 
> [Severity: Low]
> Is it necessary to disable this watchdog by default?
> 
> The watchdog timer is a core internal IP of the SoC that does not require
> board-specific configuration. Standard device tree practice is to omit
> status = "disabled" for internal IPs in the SoC .dtsi file.
> 
> The commit message states "disable it by default as it was not present
> initially". Will this require every board file inheriting this .dtsi to
> redundantly set status = "okay"?
> 

Moose board originally inherits mt8127.dtsi without watchdog node and I
do not have a moose board to test nor infos on the expected behavior. So 
I will keep this as is and advise on further comments.

Thanks!

-- 
Best regards,
Zakariya