Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Zakariya Hadrami <zkh@mailbox.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Sean Wang <sean.wang@mediatek.com>,
	 Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
	 linux-watchdog@vger.kernel.org, zkh1@proton.me
Subject: Re: [PATCH v4 4/4] ARM: dts: mediatek: Add basic support for Amazon ford board
Date: Thu, 10 Sep 2026 15:38:43 +0200	[thread overview]
Message-ID: <aqKxMgAI4bPNx78kzjYD05-zkh@mailbox.org> (raw)
In-Reply-To: <ab00e8c8-cbc2-4fe1-8900-f169aeab5a98@collabora.com>

On Thu, Sep 10, 2026 at 11:29:55AM +0200, AngeloGioacchino Del Regno wrote:
> >diff --git a/arch/arm/boot/dts/mediatek/mt8127-amazon-ford.dts b/arch/arm/boot/dts/mediatek/mt8127-amazon-ford.dts
> >new file mode 100644
> >index 000000000000..8edad5482de2
> >--- /dev/null
> >+++ b/arch/arm/boot/dts/mediatek/mt8127-amazon-ford.dts
> >@@ -0,0 +1,54 @@
> >+// SPDX-License-Identifier: GPL-2.0
> >+
> >+/dts-v1/;
> >+#include "mt8127.dtsi"
> >+
> >+/ {
> >+	model = "MediaTek MT8127 Amazon Ford";
> 
> Please be friendlier with whoever reads this model string :-)
> 
> 	model = "Amazon Fire 7 2015 (Ford)";
> 
> that's better, isn't it?

My bad, sorry!

This and the missing space in watchdog compatible fixed in v5.
Link to v5: https://patch.msgid.link/20260910-mt8127-amazon-ford-basic-v5-0-3cb9eeaffd5c@mailbox.org

Thank you very much!

> 
> After applying the proposed change,
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 
> Cheers,
> Angelo
> 
> >+	compatible = "amazon,ford", "mediatek,mt8127";
> >+	chassis-type = "tablet";

-- 
Best regards,
Zakariya

      reply	other threads:[~2026-09-10 13:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 19:37 [PATCH v4 0/4] ARM: Basic support for Amazon ford tablet (MT8127) Zakariya Hadrami via B4 Relay
2026-09-09 19:38 ` [PATCH v4 1/4] dt-bindings: watchdog: mediatek: Add MT8127 Zakariya Hadrami via B4 Relay
2026-09-09 20:42   ` Guenter Roeck
2026-09-10  9:30   ` AngeloGioacchino Del Regno
2026-09-09 19:38 ` [PATCH v4 2/4] dt-bindings: arm: mediatek: Add MT8127 Amazon ford Zakariya Hadrami via B4 Relay
2026-09-10  9:30   ` AngeloGioacchino Del Regno
2026-09-10 12:50   ` [v4,2/4] " matthias.bgg
2026-09-09 19:38 ` [PATCH v4 3/4] ARM: dts: mediatek: mt8127: Add watchdog support Zakariya Hadrami via B4 Relay
2026-09-10  9:29   ` AngeloGioacchino Del Regno
2026-09-09 19:38 ` [PATCH v4 4/4] ARM: dts: mediatek: Add basic support for Amazon ford board Zakariya Hadrami via B4 Relay
2026-09-10  9:29   ` AngeloGioacchino Del Regno
2026-09-10 13:38     ` Zakariya Hadrami [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqKxMgAI4bPNx78kzjYD05-zkh@mailbox.org \
    --to=zkh@mailbox.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    --cc=sean.wang@mediatek.com \
    --cc=wim@linux-watchdog.org \
    --cc=zkh1@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox