From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Paul Louvel <paul.louvel@bootlin.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v4 2/6] watchdog: w83627hf_wdt: Replace magic numbers with descriptive macros
Date: Mon, 19 Oct 2026 15:22:21 +0000 [thread overview]
Message-ID: <atY1rXhHo2RJbDrF@google.com> (raw)
In-Reply-To: <20261013-w83627hf_wdt-improvements-v4-2-b6f6b60a9566@bootlin.com>
On Tue, Oct 13, 2026 at 03:58:46PM +0200, Paul Louvel wrote:
> Raw hex values for Super I/O register addresses are difficult to
> understand
> without constantly consulting the datasheet. Use named macros instead.
> Also, replace macros value that contains bit position with the BIT()
> macro.
> Remove comments that doesn't help understanding the code.
>
> Signed-off-by: Paul Louvel <paul.louvel@bootlin.com>
This looks good to me. Except for a weird line wrap in the commit message,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
next prev parent reply other threads:[~2026-10-19 15:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 13:58 [PATCH v4 0/6] watchdog: w83627hf_wdt: Convert driver to the driver model and add minute support Paul Louvel
2026-10-13 13:58 ` [PATCH v4 1/6] watchdog: w83627hf_wdt: Fix watchdog identity truncation Paul Louvel
2026-10-19 15:22 ` Tzung-Bi Shih
2026-10-13 13:58 ` [PATCH v4 2/6] watchdog: w83627hf_wdt: Replace magic numbers with descriptive macros Paul Louvel
2026-10-19 15:22 ` Tzung-Bi Shih [this message]
2026-10-13 13:58 ` [PATCH v4 3/6] watchdog: w83627hf_wdt: Convert to platform driver model Paul Louvel
2026-10-19 15:22 ` Tzung-Bi Shih
2026-10-13 13:58 ` [PATCH v4 4/6] watchdog: w83627hf_wdt: Move register offsets into driver data Paul Louvel
2026-10-19 15:23 ` Tzung-Bi Shih
2026-10-13 13:58 ` [PATCH v4 5/6] watchdog: w83627hf_wdt: Store Super I/O configurations in platform data Paul Louvel
2026-10-19 15:23 ` Tzung-Bi Shih
2026-10-13 13:58 ` [PATCH v4 6/6] watchdog: w83627hf_wdt: Add minute mode counting Paul Louvel
2026-10-13 14:08 ` sashiko-bot
2026-10-13 14:22 ` Paul Louvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atY1rXhHo2RJbDrF@google.com \
--to=tzungbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=paul.louvel@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox