From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org,
Xingyu Wu <xingyu.wu@starfivetech.com>,
Ziv Xu <ziv.xu@starfivetech.com>
Subject: Re: [PATCH 2/5] watchdog: starfive-wdt: Balance pm_runtime_enable() on probe error paths
Date: Thu, 5 Nov 2026 13:46:56 +0000 [thread overview]
Message-ID: <auyI0Ber8pCmrdU-@google.com> (raw)
In-Reply-To: <20261104164445.3209560-3-linux@roeck-us.net>
On Wed, Nov 04, 2026 at 08:44:42AM -0800, Guenter Roeck wrote:
> In starfive_wdt_probe(), pm_runtime_enable() is called before attempting
> to resume the device via pm_runtime_resume_and_get() or enable its clocks
> via starfive_wdt_enable_clock(). If either call fails, probe returns
> directly without calling pm_runtime_disable(), leaving the runtime PM
> disable_depth counter unbalanced (and triggering "Unbalanced
> pm_runtime_enable!" warnings on deferred probe retries).
>
> Add an err_disable_pm error label and jump to it so pm_runtime_disable()
> is called on these error paths.
>
> Fixes: db728ea9c7be ("drivers: watchdog: Add StarFive Watchdog driver")
> Cc: Xingyu Wu <xingyu.wu@starfivetech.com>
> Cc: Ziv Xu <ziv.xu@starfivetech.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
next prev parent reply other threads:[~2026-11-05 13:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 16:44 [PATCH 0/5] watchdog: starfive-wdt: Fix runtime PM and unclocked register access bugs Guenter Roeck
2026-11-04 16:44 ` [PATCH 1/5] watchdog: starfive-wdt: Drop runtime PM reference if starting watchdog fails Guenter Roeck
2026-11-05 13:46 ` Tzung-Bi Shih
2026-11-05 14:49 ` Guenter Roeck
2026-11-05 14:52 ` Guenter Roeck
2026-11-05 15:21 ` Tzung-Bi Shih
2026-11-04 16:44 ` [PATCH 2/5] watchdog: starfive-wdt: Balance pm_runtime_enable() on probe error paths Guenter Roeck
2026-11-05 13:46 ` Tzung-Bi Shih [this message]
2026-11-04 16:44 ` [PATCH 3/5] watchdog: starfive-wdt: Avoid unclocked register access in remove and PM paths Guenter Roeck
2026-11-04 17:02 ` sashiko-bot
2026-11-04 17:58 ` Guenter Roeck
2026-11-04 16:44 ` [PATCH 4/5] watchdog: starfive-wdt: Fix runtime PM usage count leaks in probe and remove Guenter Roeck
2026-11-05 15:15 ` Tzung-Bi Shih
2026-11-04 16:44 ` [PATCH 5/5] watchdog: starfive-wdt: Drop runtime PM reference before registering watchdog Guenter Roeck
2026-11-05 15:15 ` Tzung-Bi Shih
2026-11-06 14:22 ` Tzung-Bi Shih
2026-11-06 15:13 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auyI0Ber8pCmrdU-@google.com \
--to=tzungbi@kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=xingyu.wu@starfivetech.com \
--cc=ziv.xu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox