Re: [PATCH 4/4] watchdog: it87_wdt: Keep WDTCTRL bit 3 unmodified for IT8784/IT8786

[Guenter Roeck <linux@roeck-us.net>]

On 7/11/24 14:09, James Hilliard wrote:

>> The best we could possibly do might be to add a check for the bit in register
>> 0xf1 and warn the user that they might have to use the ACPI driver if the bit
>> is set. I am not sure if that would be helpful or just add noise, though.
> 
> Do your systems which work with the it87_wdt driver have that 0xF1 bit not set?
> 

I only have one such system left, and the bit is not set on that system.
I avoid buying hardware with ITE Super-IO chips nowadays since their support
for Linux is non-existent.

> I'm thinking we should check for that bit and prevent loading the
> it87_wdt driver if

No. That would create the risk of no longer loading the driver on systems where
it currently works.

> it's set(maybe along with an override param). That way the wdat_wdt driver I

I prefer the less invasive version of logging a message. The user can then
block the it87_wdt driver if it doesn't work.

Guenter