From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Chu Guangqing <chuguangqing@inspur.com>,
wim@linux-watchdog.org, linux@roeck-us.net
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] watchdog: bd96081: Fix a spelling mistake
Date: Fri, 14 Nov 2025 11:17:02 +0200 [thread overview]
Message-ID: <b31f5017-eb85-43a6-99f3-5eabc21841ad@gmail.com> (raw)
In-Reply-To: <20251114020502.2009-1-chuguangqing@inspur.com>
Hi Chu!
Thanks for the fix!
Hm. I suppose I missed the v1. I agree with Guenter that a change log
would be nice. Then I knew what was in v1 without looking for it.
On 14/11/2025 04:05, Chu Guangqing wrote:
> The spelling of the word "initializate" is incorrect; the correct spelling is
> "initialize".
>
> Signed-off-by: Chu Guangqing <chuguangqing@inspur.com>
> ---
> drivers/watchdog/bd96801_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/bd96801_wdt.c b/drivers/watchdog/bd96801_wdt.c
> index 12b74fd2bc05..43ec23c53e62 100644
> --- a/drivers/watchdog/bd96801_wdt.c
> +++ b/drivers/watchdog/bd96801_wdt.c
> @@ -370,7 +370,7 @@ static int bd96801_wdt_probe(struct platform_device *pdev)
>
> set_bit(WDOG_HW_RUNNING, &w->wdt.status);
> } else {
> - /* If WDG is not running so we will initializate it */
> + /* If WDG is not running so we will initialize it */
I think it would be even better if the 'so' was dropped. And, as a
matter of fact, I am not sure the comment serves any real purpose here.
The code pretty much says it already. So, I am OK with either dropping
the 'so' as well, or the whole comment.
With that:
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
> ret = init_wdg_hw(w);
> if (ret)
> return ret;
Yours,
-- Matti
---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
prev parent reply other threads:[~2025-11-14 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 2:05 [PATCH v2] watchdog: bd96081: Fix a spelling mistake Chu Guangqing
2025-11-14 2:35 ` Guenter Roeck
2025-11-14 9:17 ` Matti Vaittinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b31f5017-eb85-43a6-99f3-5eabc21841ad@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=chuguangqing@inspur.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox