From: "Li, Hua Qian" <HuaQian.Li@siemens.com>
To: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "Su, Bao Cheng" <baocheng.su@siemens.com>,
"kristo@kernel.org" <kristo@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"huaqianlee@gmail.com" <huaqianlee@gmail.com>,
"nm@ti.com" <nm@ti.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Kiszka, Jan" <jan.kiszka@siemens.com>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"vigneshr@ti.com" <vigneshr@ti.com>
Subject: Re: [PATCH v4 0/3] Add support for WDIOF_CARDRESET on TI AM65x
Date: Mon, 17 Jul 2023 06:34:30 +0000 [thread overview]
Message-ID: <b82847f51ec00d873a38eab21b7ada885593aeb8.camel@siemens.com> (raw)
In-Reply-To: <625a92b8-b629-a4ef-6176-635e1b7885db@linaro.org>
On Mon, 2023-07-17 at 08:27 +0200, Krzysztof Kozlowski wrote:
> On 17/07/2023 08:24, Li, Hua Qian wrote:
> > On Mon, 2023-07-17 at 08:16 +0200, Krzysztof Kozlowski wrote:
> > > On 17/07/2023 06:07, huaqian.li@siemens.com wrote:
> > > > From: Li Hua Qian <huaqian.li@siemens.com>
> > > >
> > > > The watchdog hardware of TI AM65X platform does not support
> > > > WDIOF_CARDRESET feature, add a reserved memory to save the
> > > > watchdog
> > > > reset cause, to know if the board reboot is due to a watchdog
> > > > reset.
> > > >
> > > > Signed-off-by: Li Hua Qian <huaqian.li@siemens.com>
> > > > ---
> > > > Changes in v4:
> > > > - Fix the coding style.
> > > > - Add usage note for the reserved memory.
> > > > - Link to v3:
> > > >
> > > > https://lore.kernel.org/linux-watchdog/20230713095127.1230109-1-huaqian.li@siemens.com
> > >
> > > Much more changed. You added example in the bindings which no one
> > > asked
> > > for. Then you added multiple fake review tags to all the patches.
> > >
> > > Best regards,
> > > Krzysztof
> > >
> > Hi,
> >
> > Sorry for the wrong statement. I missed some key information and
> > missunderstood `Reviewed-by`, I treated `Reviewed-by` as `Who
> > has reviewed`.
>
> But you don't have even that information who has reviewed! Where do
> you
> see any reviews coming from me for patch #2? Where do you see reviews
> from Rob for patch #3?
>
> Best regards,
> Krzysztof
>
I got these information from my email thread. Anyway I made a stupid
mistake, sorry for wasting your time.
By the way, when you wrote the following in '[PATCH v3 1/3] dt-
bindings: watchdog: ti,rti-wdt: Add support for WDIOF_CARDRESET', you
were kind of saying that it looks good to you if I remove the extra
empty line, right?
In any case:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Li Hua Qian
next prev parent reply other threads:[~2023-07-17 6:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 4:07 [PATCH v4 0/3] Add support for WDIOF_CARDRESET on TI AM65x huaqian.li
2023-07-17 4:07 ` [PATCH v4 1/3] dt-bindings: watchdog: ti,rti-wdt: Add support for WDIOF_CARDRESET huaqian.li
2023-07-17 5:15 ` Guenter Roeck
2023-07-17 7:13 ` Li, Hua Qian
2023-07-17 6:13 ` Krzysztof Kozlowski
2023-07-17 6:15 ` Krzysztof Kozlowski
2023-07-17 7:17 ` Conor Dooley
2023-07-17 7:23 ` Li, Hua Qian
2023-07-17 4:07 ` [DONOTMERGE PATCH v4 2/3] arm64: dts: ti: Add reserved memory for watchdog huaqian.li
2023-07-17 6:14 ` Krzysztof Kozlowski
2023-07-17 4:07 ` [PATCH v4 3/3] watchdog:rit_wdt: Add support for WDIOF_CARDRESET huaqian.li
2023-07-17 6:14 ` Krzysztof Kozlowski
2023-07-17 6:16 ` [PATCH v4 0/3] Add support for WDIOF_CARDRESET on TI AM65x Krzysztof Kozlowski
2023-07-17 6:24 ` Li, Hua Qian
2023-07-17 6:27 ` Krzysztof Kozlowski
2023-07-17 6:34 ` Li, Hua Qian [this message]
2023-07-17 6:43 ` Krzysztof Kozlowski
2023-07-17 6:49 ` Li, Hua Qian
2023-07-17 6:28 ` Li, Hua Qian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b82847f51ec00d873a38eab21b7ada885593aeb8.camel@siemens.com \
--to=huaqian.li@siemens.com \
--cc=baocheng.su@siemens.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=huaqianlee@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).