Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Andrej Picej <andrej.picej@norik.com>
To: Guenter Roeck <linux@roeck-us.net>,
	Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: imx2_wdg: Declare local symbols static
Date: Thu, 2 Mar 2023 09:03:15 +0100	[thread overview]
Message-ID: <be465a23-7f31-004c-3bb7-d8021187da5d@norik.com> (raw)
In-Reply-To: <20230228151648.4087637-1-linux@roeck-us.net>

On 28. 02. 23 16:16, Guenter Roeck wrote:
> 0-day complains:
> 
> drivers/watchdog/imx2_wdt.c:442:22: sparse:
> 	symbol 'imx_wdt' was not declared. Should it be static?
> drivers/watchdog/imx2_wdt.c:446:22: sparse:
> 	symbol 'imx_wdt_legacy' was not declared. Should it be static?
> 
> Declare as static variables.
> 
> Fixes: e42c73f1ef0d ("watchdog: imx2_wdg: suspend watchdog in WAIT mode")
> Cc: Andrej Picej <andrej.picej@norik.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Hi Guenter,

thanks for the fix. Sorry for the trouble.

Best regards,
Andrej

      reply	other threads:[~2023-03-02  9:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-28 15:16 [PATCH] watchdog: imx2_wdg: Declare local symbols static Guenter Roeck
2023-03-02  8:03 ` Andrej Picej [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be465a23-7f31-004c-3bb7-d8021187da5d@norik.com \
    --to=andrej.picej@norik.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox