Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	bod.linux@nxsw.ie, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v3 4/4] watchdog: qcom: add support to read the restart reason from IMEM
Date: Fri, 2 May 2025 22:01:06 +0530	[thread overview]
Message-ID: <c2b0b0b3-6fa9-46b8-84ef-81314965848a@oss.qualcomm.com> (raw)
In-Reply-To: <gmoe3ykmns5hmmz6hdyxgzxiejb3nycghhvt3pgjysq6xa2zni@wpqyuz2pj5vy>


On 5/2/2025 8:24 PM, Dmitry Baryshkov wrote:
>> +static int  qcom_wdt_get_restart_reason(struct qcom_wdt *wdt,
>> +					const struct qcom_wdt_match_data *data)
>> +{
>> +	struct regmap *imem;
>> +	unsigned int val;
>> +	int ret;
>> +
>> +	imem = syscon_regmap_lookup_by_compatible(data->imem_compatible);
>> +	if (IS_ERR(imem))
>> +		return PTR_ERR(imem);
> Why? Just pass the syscon directly via DT.


Ack. As replied to Konrad, will rework this.


  reply	other threads:[~2025-05-02 16:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-02 13:17 [PATCH v3 0/4] Add support to read the restart reason from IMEM Kathiravan Thirumoorthy
2025-05-02 13:17 ` [PATCH v3 1/4] dt-bindings: sram: qcom,imem: Document IPQ5424 compatible Kathiravan Thirumoorthy
2025-05-02 13:17 ` [PATCH v3 2/4] arm64: dts: qcom: ipq5424: Add the IMEM node Kathiravan Thirumoorthy
2025-05-02 13:17 ` [PATCH v3 3/4] watchdog: qcom: introduce the device data for IPQ5424 watchdog device Kathiravan Thirumoorthy
2025-05-02 13:36   ` Guenter Roeck
2025-05-02 14:53   ` Dmitry Baryshkov
2025-05-02 16:01     ` Kathiravan Thirumoorthy
2025-05-02 13:17 ` [PATCH v3 4/4] watchdog: qcom: add support to read the restart reason from IMEM Kathiravan Thirumoorthy
2025-05-02 13:33   ` Krzysztof Kozlowski
2025-05-02 16:02     ` Kathiravan Thirumoorthy
2025-05-02 13:33   ` Guenter Roeck
2025-05-02 16:08     ` Kathiravan Thirumoorthy
2025-05-02 22:13       ` Konrad Dybcio
2025-05-02 14:03   ` Konrad Dybcio
2025-05-02 16:28     ` Kathiravan Thirumoorthy
2025-05-02 22:23       ` Konrad Dybcio
2025-05-06 11:01         ` Kathiravan Thirumoorthy
2025-05-14 13:15           ` Kathiravan Thirumoorthy
2025-05-14 18:05             ` Guenter Roeck
2025-05-16 11:18             ` Konrad Dybcio
2025-05-16 12:52               ` Kathiravan Thirumoorthy
2025-05-16 16:35                 ` Konrad Dybcio
2025-05-17 10:41                   ` Kathiravan Thirumoorthy
2025-05-02 14:54   ` Dmitry Baryshkov
2025-05-02 16:31     ` Kathiravan Thirumoorthy [this message]
2025-08-11 18:40 ` (subset) [PATCH v3 0/4] Add " Bjorn Andersson
2025-08-25 12:11   ` Kathiravan Thirumoorthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2b0b0b3-6fa9-46b8-84ef-81314965848a@oss.qualcomm.com \
    --to=kathiravan.thirumoorthy@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=bod.linux@nxsw.ie \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox