Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Antonio Borneo <antonio.borneo@foss.st.com>
To: Guenter Roeck <linux@roeck-us.net>, Julius Werner <jwerner@chromium.org>
Cc: Evan Benn <evanbenn@chromium.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	<linux-watchdog@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] watchdog: arm_smc_wdt: get wdt status through SMCWD_GET_TIMELEFT
Date: Tue, 20 May 2025 10:49:46 +0200	[thread overview]
Message-ID: <cf096db75e9a321ee86eeb1685f4f1f5cb140e4b.camel@foss.st.com> (raw)
In-Reply-To: <2bb28691-def0-4365-98e0-7f53d4d19966@roeck-us.net>

On Mon, 2025-05-19 at 18:13 -0700, Guenter Roeck wrote:
> On 5/19/25 17:12, Julius Werner wrote:
> > I don't really know about the issue Guenter mentioned, but otherwise,
> > from the driver's side this looks good to me.
> > 
> 
> It should just be
>         set_bit(WDOG_HW_RUNNING, &wdd->status);
> 
> There should be no dependency on CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED.
> 
> Guenter
> 

Thanks for the review!
I agree on Guenter's comment and I will send a V2 shortly.

Regards
Antonio

  reply	other threads:[~2025-05-20  8:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19 17:00 [PATCH] watchdog: arm_smc_wdt: get wdt status through SMCWD_GET_TIMELEFT Antonio Borneo
2025-05-19 17:58 ` Guenter Roeck
2025-05-20  0:12   ` Julius Werner
2025-05-20  1:13     ` Guenter Roeck
2025-05-20  8:49       ` Antonio Borneo [this message]
2025-05-20  8:59 ` [PATCH v2] " Antonio Borneo
2025-05-20 18:48   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf096db75e9a321ee86eeb1685f4f1f5cb140e4b.camel@foss.st.com \
    --to=antonio.borneo@foss.st.com \
    --cc=evanbenn@chromium.org \
    --cc=jwerner@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox