From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <garsilva@embeddedor.com>
Return-path: <garsilva@embeddedor.com>
Subject: Re: [PATCH] watchdog: ts72xx_wdt: constify watchdog_ops structure
To: Guenter Roeck <linux@roeck-us.net>, Wim Van Sebroeck <wim@iguana.be>
References: <20170708001840.GA8758@embeddedgus>
 <ef62d519-2b18-816a-5253-89f5fc276332@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Message-ID: <d8b083d8-baf1-e67c-8f12-ea07baed7079@embeddedor.com>
Date: Sun, 16 Jul 2017 23:02:37 -0500
MIME-Version: 1.0
In-Reply-To: <ef62d519-2b18-816a-5253-89f5fc276332@roeck-us.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
List-ID: <linux-watchdog@vger.kernel.org>



On 07/07/2017 08:44 PM, Guenter Roeck wrote:
> On 07/07/2017 05:18 PM, Gustavo A. R. Silva wrote:
>> Check for watchdog_ops structures that are only stored in the ops 
>> field of
>> a watchdog_device structure. This field is declared const, so 
>> watchdog_ops
>> structures that have this property can be declared as const also.
>>
>> This issue was detected using Coccinelle and the following semantic 
>> patch:
>>
>> @r
>> disable optional_qualifier@
>> identifier i;
>> position p;
>> @@
>> static struct watchdog_ops i@p = { ... };
>>
>> @ok@
>> identifier r.i;
>> struct watchdog_device e;
>> position p;
>> @@
>> e.ops = &i@p;
>>
>> @bad@
>> position p != {r.p,ok.p};
>> identifier r.i;
>> struct watchdog_ops e;
>> @@
>> e@i@p
>>
>> @depends on !bad disable optional_qualifier@
>> identifier r.i;
>> @@
>> static
>> +const
>>   struct watchdog_ops i = { ... };
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>

Thank you, Guenter.

>> ---
>>   drivers/watchdog/ts72xx_wdt.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/ts72xx_wdt.c 
>> b/drivers/watchdog/ts72xx_wdt.c
>> index 17c25da..811e43c 100644
>> --- a/drivers/watchdog/ts72xx_wdt.c
>> +++ b/drivers/watchdog/ts72xx_wdt.c
>> @@ -112,7 +112,7 @@ static const struct watchdog_info 
>> ts72xx_wdt_ident = {
>>       .identity        = "TS-72XX WDT",
>>   };
>>   -static struct watchdog_ops ts72xx_wdt_ops = {
>> +static const struct watchdog_ops ts72xx_wdt_ops = {
>>       .owner        = THIS_MODULE,
>>       .start        = ts72xx_wdt_start,
>>       .stop        = ts72xx_wdt_stop,
>>
>

-- 
Gustavo A. R. Silva