From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9EF3C4321E for ; Mon, 5 Dec 2022 03:52:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231318AbiLEDwb (ORCPT ); Sun, 4 Dec 2022 22:52:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231254AbiLEDwb (ORCPT ); Sun, 4 Dec 2022 22:52:31 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 298AC12D08; Sun, 4 Dec 2022 19:52:27 -0800 (PST) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 95AC424E1CF; Mon, 5 Dec 2022 11:52:23 +0800 (CST) Received: from EXMBX161.cuchost.com (172.16.6.71) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 5 Dec 2022 11:52:23 +0800 Received: from [192.168.125.128] (113.72.146.33) by EXMBX161.cuchost.com (172.16.6.71) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 5 Dec 2022 11:52:22 +0800 Message-ID: Date: Mon, 5 Dec 2022 11:49:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v1 1/3] dt-bindings: watchdog: Add watchdog for StarFive Content-Language: en-US To: Krzysztof Kozlowski CC: Rob Herring , Paul Walmsley , , , , "Palmer Dabbelt" , Albert Ou , "Wim Van Sebroeck" , Philipp Zabel , Samin Guo , Guenter Roeck , References: <20221202093943.149674-1-xingyu.wu@starfivetech.com> <20221202093943.149674-2-xingyu.wu@starfivetech.com> From: Xingyu Wu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.146.33] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX161.cuchost.com (172.16.6.71) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 2022/12/2 18:46, Krzysztof Kozlowski wrote: > On 02/12/2022 10:39, xingu.wu wrote: >> From: Xingyu Wu >> >> Add bindings to describe the watchdog for the StarFive SoCs. >> >> Signed-off-by: Xingyu Wu >> --- >> .../bindings/watchdog/starfive,wdt.yaml | 77 +++++++++++++++++++ >> 1 file changed, 77 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml >> >> diff --git a/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml >> new file mode 100644 >> index 000000000000..ece3e80153a0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/watchdog/starfive,wdt.yaml > > Filename should be based on compatible. You do not allow here any other > models... If you intent and you are 100% sure you will grow with new > models, make it maybe a family-based name. First, thank you for your reply. We have some other SoCs like JH7100 would use this watchdog driver, but we now use JH7110 as our main release chip. As you say, should we use "starfive,jh71xx-wdt.yaml" as filename? >> @@ -0,0 +1,77 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/watchdog/starfive,wdt.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive Watchdog >> + >> +allOf: >> + - $ref: "watchdog.yaml#" > > Drop quotes. Will fix. >> + >> +maintainers: >> + - Samin Guo >> + - Xingyu Wu >> + >> +properties: >> + compatible: >> + const: starfive,jh7110-wdt >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + items: >> + - description: Core clock >> + - description: APB clock >> + >> + clock-names: >> + items: >> + - const: core_clk > > Drop _clk Will fix. > >> + - const: apb_clk > > Drop _clk Will fix. > >> + >> + resets: >> + items: >> + - description: APB reset >> + - description: Core reset >> + >> + reset-names: >> + items: >> + - const: rst_apb > > Drop rst_ Will fix. > >> + - const: rst_core > > Ditto Will fix. > >> + >> + timeout-sec: true >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + - clock-names >> + - resets >> + - reset-names >> + - timeout-sec >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + watchdog@13070000 { >> + compatible = "starfive,jh7110-wdt"; > > Use 4 spaces for example indentation. Will fix. > >> + reg = <0x13070000 0x10000>; >> + interrupts = <68>; >> + clocks = <&syscrg_clk JH7110_SYSCLK_WDT_CORE>, >> + <&syscrg_clk JH7110_SYSCLK_WDT_APB>; >> + clock-names = "core_clk", "apb_clk"; >> + resets = <&syscrg_rst JH7110_SYSRST_WDT_APB>, >> + <&syscrg_rst JH7110_SYSRST_WDT_CORE>; >> + reset-names = "rst_apb", "rst_core"; >> + timeout-sec = <15>; >> + }; >> + > > Drop trailing line. Will fix. Best regards, Xingyu Wu