From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kousik Sanagavarapu <five231003@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>, Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 3/3] ARM: dts: davinci, keystone: correct watchdog nodenames
Date: Mon, 22 Jul 2024 10:13:59 +0200 [thread overview]
Message-ID: <e0e36e05-f565-48ad-9309-854b6fb7985c@kernel.org> (raw)
In-Reply-To: <20240721170840.15569-4-five231003@gmail.com>
On 21/07/2024 18:28, Kousik Sanagavarapu wrote:
> Using "wdt" instead of "watchdog" for watchdog timer nodes doesn't allow
> for validation with the corresponding dtschema and gives errors
>
> $ make CHECK_DTBS=y DT_SCHEMA_FILES=ti,davinci-wdt.yaml \
> ti/keystone/keystone-k2g-ice.dtb
>
> DTC_CHK arch/arm/boot/dts/ti/keystone/keystone-k2g-ice.dtb
> arch/arm/boot/dts/ti/keystone/keystone-k2g-ice.dtb:
> wdt@02250000: $nodename:0: 'wdt@02250000' does not match
> '^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$'
> from schema $id:
> http://devicetree.org/schemas/watchdog/ti,davinci-wdt.yaml#
>
> Therefore change "wdt@" to "watchdog@".
>
> While at it, remove "ti,davinci-wdt" compatible from the keystone dts
> code.
That's entirely unrelated patch. Don't mix simple cleanups with patches
affecting ABI and users. Also, explain why.
>
> Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>
> ---
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-22 8:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-21 16:28 [PATCH 0/3] ti: davinci, keystone: txt to yaml Kousik Sanagavarapu
2024-07-21 16:28 ` [PATCH 1/3] dt-bindings: timer: ti,davinci-timer: convert to dtschema Kousik Sanagavarapu
2024-07-22 8:11 ` Krzysztof Kozlowski
2024-07-22 12:59 ` Kousik Sanagavarapu
2024-07-21 16:28 ` [RFC PATCH 2/3] dt-bindings: watchdog: ti,davinci-wdt: " Kousik Sanagavarapu
2024-07-22 8:15 ` Krzysztof Kozlowski
2024-07-22 13:12 ` Kousik Sanagavarapu
2024-07-22 13:50 ` Krzysztof Kozlowski
2024-07-22 14:02 ` Kousik Sanagavarapu
2024-07-22 14:08 ` Krzysztof Kozlowski
2024-07-21 16:28 ` [RFC PATCH 3/3] ARM: dts: davinci, keystone: correct watchdog nodenames Kousik Sanagavarapu
2024-07-22 8:13 ` Krzysztof Kozlowski [this message]
2024-07-22 13:21 ` Kousik Sanagavarapu
2024-07-22 14:07 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0e36e05-f565-48ad-9309-854b6fb7985c@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=five231003@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=ssantosh@kernel.org \
--cc=tglx@linutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox