From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2F8EC77B60 for ; Wed, 29 Mar 2023 13:28:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229703AbjC2N2a (ORCPT ); Wed, 29 Mar 2023 09:28:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjC2N23 (ORCPT ); Wed, 29 Mar 2023 09:28:29 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90135DC; Wed, 29 Mar 2023 06:28:28 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 2C9FD6602173; Wed, 29 Mar 2023 14:28:26 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1680096507; bh=dPurwcCzBh53xYIIc/DWqjdYl2N/RjAfRStrUt2ymbg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YrYXYXWRyb7oA/U0bSzyOSnFThy2Xc41itY9aUfaIB03t66o9TALGdUOc/VUTqIl/ fjbd9dVCH8uSKhSJ1w4GgWpG7BaH51gbOtuFJRWY79Sjyv5LtxuAJkgdncpwY3OXGX QFCIBe2ofhVNluIrHyTpBRPGz4p3Ywd+Jo1cUB9/yqLPdgP+829FpG7oYtsFbEYIJW 6MQBWMTbKOcR+cb/GuKsWVQRW1RRhIHnOI3merM6sWlYnyMZmF6d2mjQgdaRqbZFJH j8qkmwpzgZ76l6YMvx4OoWLopNPIBmEtTNygEnoP0Dn9okK8HNVFPPxKtTuxFCKYsX 6XeN1qyHZ40pA== Message-ID: Date: Wed, 29 Mar 2023 15:28:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 14/17] arm64: dts: mediatek: add OPP support for mt8365 SoC Content-Language: en-US To: Alexandre Mergnat , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Chaotian Jing , Ulf Hansson , Wenbin Mei , Linus Walleij , Zhiyong Tao , =?UTF-8?Q?Bernhard_Rosenkr=c3=a4nzer?= Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, Alexandre Bailon , Fabien Parent , Amjad Ouled-Ameur References: <20230203-evk-board-support-v3-0-0003e80e0095@baylibre.com> <20230203-evk-board-support-v3-14-0003e80e0095@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230203-evk-board-support-v3-14-0003e80e0095@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Il 29/03/23 10:54, Alexandre Mergnat ha scritto: > In order to have cpufreq support, this patch adds generic Operating > Performance Points support. > > Signed-off-by: Alexandre Mergnat > --- > arch/arm64/boot/dts/mediatek/mt8365.dtsi | 85 ++++++++++++++++++++++++++++++++ > 1 file changed, 85 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi > index 394a5a61be59..c3ea3cc97a47 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi > @@ -20,6 +20,75 @@ cpus { > #address-cells = <1>; > #size-cells = <0>; > > + cluster0_opp: opp-table-0 { > + compatible = "operating-points-v2"; > + opp-shared; One blank line here please, makes it slightly more readable. > + opp-850000000 { > + opp-hz = /bits/ 64 <850000000>; > + opp-microvolt = <650000>; > + }; Also, my personal preference is to also leave a blank line between each opp-xxxx subnode, but that's your choice. Everything else looks good.