From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CC82C77B7D for ; Mon, 15 May 2023 11:55:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241450AbjEOLz2 (ORCPT ); Mon, 15 May 2023 07:55:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241309AbjEOLzO (ORCPT ); Mon, 15 May 2023 07:55:14 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A35A2D63; Mon, 15 May 2023 04:44:29 -0700 (PDT) Received: from [IPV6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab] (unknown [IPv6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id E0C8D66031D7; Mon, 15 May 2023 12:44:26 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1684151067; bh=rDyvSJh2ELejvMz6JJ1HfRpjB8o4ib0qqoQwRrpvqj4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WTYBOhcjSLYsGnY9G9lV204YnWZ8jpu0eh800cs4me6vSP5bLI5SHZt+66bdNDhOa /affCIm0aFqN1v5KeAUt9br+lVC0fHsVVK4AS1KZOJ1wsEdjS3xVlBa+cyPQF1Fus4 atY6l+7mqaa0blZL/RCDQWN971SUaym5vYyITXCIbxU/QdwfoFeGNEIcrJSv0mJGKG hUL18PnvqnezQRcOxHJhjJCuUf8W+r3uEhZoyJdgeSemWqtU4uGn77S7jHEWUQbk0+ 4cbyOB9fP3OawQyvm3KKDRxz7ynNvmkqeN27ouDTE90RU5VxOKy4fquXFdu9qf58YZ I50NfCyBgRTDg== Message-ID: Date: Mon, 15 May 2023 13:44:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v7 06/11] arm64: dts: mediatek: set vmc regulator as always on Content-Language: en-US To: amergnat@baylibre.com, Catalin Marinas , Will Deacon , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Conor Dooley Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, Fabien Parent , Kevin Hilman References: <20230203-evk-board-support-v7-0-98cbdfac656e@baylibre.com> <20230203-evk-board-support-v7-6-98cbdfac656e@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230203-evk-board-support-v7-6-98cbdfac656e@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Il 11/05/23 18:29, amergnat@baylibre.com ha scritto: > From: Fabien Parent > > On downstream, we observe that the MSDC IP (used by the emmc, the micro > SD card and the WiFi) isn't working properly if the VMC regulator is > shutdown. > > Make sure it is always on. I don't understand the power tree of this board: if your VQMMC is VIO18 and *not* VMC, why is that required? The real question is if we're facing one more supply as requirement for newer MediaTek SoCs and whether it would be a better idea to add that to the actual driver (and/or as a power domain supply!!!) to both better represent the power tree and to eventually allow deep power saving states. Regards, Angelo > > Signed-off-by: Fabien Parent > Tested-by: Kevin Hilman > Signed-off-by: Alexandre Mergnat > --- > arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > index 752007d0598e..5d69b39c8746 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts > @@ -137,6 +137,11 @@ &mt6357_pmic { > #interrupt-cells = <2>; > }; > > +/* Needed by MSDC IP */ > +&mt6357_vmc_reg { > + regulator-always-on; > +}; > + > &pio { > gpio_keys: gpio-keys-pins { > pins { >