Re: [PATCH v9 05/12] mfd: nct6694: Move module type macros to shared header

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] mfd: driver-specific header modified in global include/linux/mfd/
--

commit d639c18480f1ac35c44ced9c53986d041709e15f
Author: Ming Yu <a0282524688@gmail.com>

mfd: nct6694: Move module type macros to shared header

This commit moves module type macros from individual sub-device drivers into a
shared header include/linux/mfd/nct6694.h. The rationale is that the upcoming
HIF transport needs to recognise these module types. The change centralizes
definitions previously spread across several subsystems.

> diff --git a/include/linux/mfd/nct6694.h b/include/linux/mfd/nct6694.h
> index 69e4652cf16c4..d46ae34a497e1 100644
> --- a/include/linux/mfd/nct6694.h
> +++ b/include/linux/mfd/nct6694.h
> @@ -8,6 +8,15 @@
>  #ifndef __MFD_NCT6694_H
>  #define __MFD_NCT6694_H
>  
> +#define NCT6694_HWMON_MOD	0x00
> +#define NCT6694_PWM_MOD		0x01
> +#define NCT6694_I2C_MOD		0x03
> +#define NCT6694_CANFD_MOD	0x05
> +#define NCT6694_WDT_MOD		0x07
> +#define NCT6694_RTC_MOD		0x08
> +#define NCT6694_RPT_MOD		0xFF
> +#define NCT6694_GPIO_MOD	NCT6694_RPT_MOD
> +

[Severity: Low]
Are these driver-specific module type macros only used by the parent and its
immediate children?

According to MFD subsystem guidelines, driver-specific header files should not
be placed in the global include/linux/mfd/ directory if they are only used
by the parent and its immediate children. They should be kept local to
drivers/mfd/ instead.

Does this addition of driver-specific macros to the global header violate
the subsystem architecture guidelines?

>  #define NCT6694_VENDOR_ID	0x0416
>  #define NCT6694_PRODUCT_ID	0x200B
>  #define NCT6694_INT_IN_EP	0x01

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013063259.2734757-1-a0282524688@gmail.com?part=5