From: sashiko-bot@kernel.org
To: "Yureka Lilian" <yureka@cyberchaos.dev>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 10/10] arm64: dts: apple: Add minimal t604x (M4 Pro/Max) device trees
Date: Wed, 14 Oct 2026 07:04:08 +0000 [thread overview]
Message-ID: <sashiko-outbox-170921@kernel.org> (raw)
In-Reply-To: <20261014-apple-m4-pro-max-initial-devicetrees-v2-10-961edd8d661b@cyberchaos.dev>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kbuild: Makefile entries for device trees are not sorted alphabetically
--
commit 82cbbc1479b59d13a418d2b1deaeea36cb85e6fa
Author: Yureka Lilian <yureka@cyberchaos.dev>
arm64: dts: apple: Add minimal t604x (M4 Pro/Max) device trees
This commit introduces minimal device trees for the Apple M4 Pro and M4
Max systems, including multiple MacBook Pro, Mac mini, and Mac Studio
models. It also wires up the new targets in the arm64 Apple device tree
Makefile.
> diff --git a/arch/arm64/boot/dts/apple/Makefile b/arch/arm64/boot/dts/apple/Makefile
> index 4f31beeb11ac4..12fc777405b3f 100644
> --- a/arch/arm64/boot/dts/apple/Makefile
> +++ b/arch/arm64/boot/dts/apple/Makefile
> @@ -94,6 +94,12 @@ dtb-$(CONFIG_ARCH_APPLE) += t6031-j516c.dtb
> dtb-$(CONFIG_ARCH_APPLE) += t6032-j575d.dtb
> dtb-$(CONFIG_ARCH_APPLE) += t6034-j514m.dtb
> dtb-$(CONFIG_ARCH_APPLE) += t6034-j516m.dtb
> +dtb-$(CONFIG_ARCH_APPLE) += t6040-j773s.dtb
[Severity: Low]
This isn't a bug, but could we keep these build targets alphabetically
sorted? Placing t6040-j773s.dtb before the j614s and j616s entries breaks
the sequential ordering convention, which is typically maintained to prevent
merge conflicts when multiple patch series add new devices in parallel.
> +dtb-$(CONFIG_ARCH_APPLE) += t6040-j614s.dtb
> +dtb-$(CONFIG_ARCH_APPLE) += t6040-j616s.dtb
> +dtb-$(CONFIG_ARCH_APPLE) += t6041-j575c.dtb
> +dtb-$(CONFIG_ARCH_APPLE) += t6041-j614c.dtb
> +dtb-$(CONFIG_ARCH_APPLE) += t6041-j616c.dtb
> dtb-$(CONFIG_ARCH_APPLE) += t8112-j413.dtb
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261014-apple-m4-pro-max-initial-devicetrees-v2-0-961edd8d661b@cyberchaos.dev?part=10
prev parent reply other threads:[~2026-10-14 7:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 6:56 [PATCH v2 00/10] Initial Apple Silicon M4 Pro/Max device trees and dt-bindings Yureka Lilian
2026-10-14 6:56 ` [PATCH v2 01/10] dt-bindings: watchdog: apple,wdt: Add t6041 compatible Yureka Lilian
2026-10-14 6:56 ` [PATCH v2 02/10] dt-bindings: interrupt-controller: apple,aic2: " Yureka Lilian
2026-10-14 6:56 ` [PATCH v2 03/10] dt-bindings: arm: cpus: Add Apple M4 Pro/Max CPU core compatibles Yureka Lilian
2026-10-14 6:56 ` [PATCH v2 04/10] dt-bindings: arm: power: apple,pmgr-pwrstate: Add t6041 compatible Yureka Lilian
2026-10-14 6:56 ` [PATCH v2 05/10] dt-bindings: arm: apple: apple,pmgr: " Yureka Lilian
2026-10-14 6:56 ` [PATCH v2 06/10] dt-bindings: pwm: apple,s5l-fpwm: " Yureka Lilian
2026-10-14 9:12 ` Uwe Kleine-König
2026-10-14 6:56 ` [PATCH v2 07/10] dt-bindings: pinctrl: apple,pinctrl: " Yureka Lilian
2026-10-14 6:56 ` [PATCH v2 08/10] dt-bindings: i2c: apple,i2c: " Yureka Lilian
2026-10-14 6:56 ` [PATCH v2 09/10] dt-bindings: arm: apple: Add M4 Pro/Max based devices Yureka Lilian
2026-10-14 6:56 ` [PATCH v2 10/10] arm64: dts: apple: Add minimal t604x (M4 Pro/Max) device trees Yureka Lilian
2026-10-14 7:04 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-170921@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yureka@cyberchaos.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox