From: sashiko-bot@kernel.org
To: "Carl Smith" <carl.smith@alliedtelesis.co.nz>
Cc: linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: octeon-wdt: Add a panic_on_timeout parameter
Date: Fri, 23 Oct 2026 19:38:55 +0000 [thread overview]
Message-ID: <sashiko-outbox-183127@kernel.org> (raw)
In-Reply-To: <20261023191530.327734-1-carl.smith@alliedtelesis.co.nz>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] watchdog: octeon-wdt: undocumented panic_on_timeout module parameter
--
commit 3f30c4c06ea7c605e88ff05165b08aa4592f832c
Author: Carl Smith <carl.smith@alliedtelesis.co.nz>
watchdog: octeon-wdt: Add a panic_on_timeout parameter
This commit adds a panic_on_timeout module parameter to the octeon-wdt driver
so that a kernel panic can be triggered when the software heartbeat expires,
allowing crash loggers such as mtdoops to record the event before the
hardware watchdog resets the board.
> diff --git a/drivers/watchdog/octeon-wdt-main.c b/drivers/watchdog/octeon-wdt-main.c
> index 171b46d780e6f..d29a638998475 100644
> --- a/drivers/watchdog/octeon-wdt-main.c
> +++ b/drivers/watchdog/octeon-wdt-main.c
> @@ -107,6 +107,11 @@ module_param(disable, int, 0444);
> MODULE_PARM_DESC(disable,
> "Disable the watchdog entirely (default=0)");
>
> +static bool panic_on_timeout;
> +module_param(panic_on_timeout, bool, 0444);
> +MODULE_PARM_DESC(panic_on_timeout,
> + "Panic when the heartbeat expires, instead of a silent reset (default=0)");
[Severity: Low]
Should the new panic_on_timeout parameter in drivers/watchdog/octeon-wdt-main.c
also be documented in Documentation/admin-guide/kernel-parameters.txt (and
Documentation/watchdog/watchdog-parameters.rst)?
Because panic_on_timeout is registered with module_param() with mode 0444 and
CONFIG_OCTEON_WDT defaults to built-in on CAVIUM_OCTEON_SOC, passing
octeon_wdt.panic_on_timeout on the kernel command line is the primary way to
enable it when built-in, and kernel parameters exposed via module_param() are
expected to be documented in Documentation/admin-guide/kernel-parameters.txt.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261023191530.327734-1-carl.smith@alliedtelesis.co.nz?part=1
next prev parent reply other threads:[~2026-10-23 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 19:15 [PATCH] watchdog: octeon-wdt: Add a panic_on_timeout parameter Carl Smith
2026-10-23 19:38 ` sashiko-bot [this message]
2026-10-25 18:55 ` Carl Smith
2026-10-26 22:12 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-183127@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=carl.smith@alliedtelesis.co.nz \
--cc=linux-watchdog@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox