Re: [PATCH v3 13/13] arm64: dts: st: enable iwdg2 on stm32mp2xx ST boards

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: st: unresolved rcc phandle and clock macros in
  stm32mp215f-dk iwdg2
--

commit 7a43e1911df9f04894384d16f6721b48e26c2793
Author: Antonio Borneo <antonio.borneo@foss.st.com>

arm64: dts: st: enable iwdg2 on stm32mp2xx ST boards

This commit enables the iwdg2 watchdog node and assigns the watchdog0
alias to arm_wdt on STM32MP2xx ST board device trees.

> diff --git a/arch/arm64/boot/dts/st/stm32mp215f-dk.dts b/arch/arm64/boot/dts/st/stm32mp215f-dk.dts
> index a1285abc80ca5..c7ab340a7e4dc 100644
> --- a/arch/arm64/boot/dts/st/stm32mp215f-dk.dts
> +++ b/arch/arm64/boot/dts/st/stm32mp215f-dk.dts

[ ... ]

> @@ -48,6 +49,11 @@ &bsec {
>  	bootph-all;
>  };
>  
> +&iwdg2 {
> +	timeout-sec = <32>;
> +	status = "okay";
> +};
> +
>  &usart2 {
>  	status = "okay";
>  };

[Severity: High]
Does building stm32mp215f-dk.dtb fail with syntax and unresolved phandle
errors here?

The iwdg1 and iwdg2 nodes added in commit "arm64: dts: st: add iwdg1 and
iwdg2 support to stm32mp211" reference clocks = <&rcc CK_BUS_IWDG2>,
<&scmi_clk CK_SCMI_LSI>, but arch/arm64/boot/dts/st/stm32mp211.dtsi
neither includes dt-bindings/clock/st,stm32mp21-rcc.h nor defines an rcc
label.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106163429.618392-1-antonio.borneo@foss.st.com?part=13