linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jean-Pierre Tosoni" <jp.tosoni@acksys.fr>
To: "'Felix Fietkau'" <nbd@openwrt.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: RE: [RFC v2] mac80211: Use libnl-configurable values for retry counts
Date: Tue, 2 Jul 2013 19:40:20 +0200	[thread overview]
Message-ID: <000101ce774b$3925e380$ab71aa80$@acksys.fr> (raw)
In-Reply-To: <51D2DAB9.4050002@openwrt.org>

Hi Felix,

Sorry to use your time again...

> But much more important than that is to not cause regressions for other
> people via aggressive packet dropping.

Agreed, but see below.

> If you put the code in minstrel (and minstrel_ht), it not only allows
> making a better tradeoff for retry handling, the code also doesn't have
> to be run for every single packet. You can run it during the rate
> control stats update.

OK, I'll have a look at that part now.

> 
> The reduction of retry attempts definitely needs to be balanced
> properly. Retries with max_prob_rate can be more important than retries
> with max_tp_rate, but there needs to be a minimum for each of those.

This leads to a question about regressions and backward compatibility:

Since minstrel can compute as much as 28 retries for a frame,
And since the (standard) default value for "short_frame_max_tx_count" is 7,

... there is no way I can enforce the configured value while keeping
minstrel counts by default !
The standard itself gives a very aggressive limit! Or am I mistaken about
the significance of this configuration parameter ?

Jean-Pierre


  reply	other threads:[~2013-07-02 17:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27 16:40 [RFC v2] mac80211: Use libnl-configurable values for retry counts Jean-Pierre Tosoni
2013-06-29 20:08 ` Felix Fietkau
2013-07-01  8:34   ` Jean-Pierre Tosoni
2013-07-01  9:04     ` Felix Fietkau
2013-07-02 13:28   ` Jean-Pierre Tosoni
2013-07-02 13:50     ` Felix Fietkau
2013-07-02 17:40       ` Jean-Pierre Tosoni [this message]
2013-07-02 18:05         ` Felix Fietkau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000101ce774b$3925e380$ab71aa80$@acksys.fr' \
    --to=jp.tosoni@acksys.fr \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).