From: "Rakesh Pillai" <pillair@codeaurora.org>
To: "'Brian Norris'" <briannorris@chromium.org>
Cc: "'ath10k'" <ath10k@lists.infradead.org>,
"'linux-wireless'" <linux-wireless@vger.kernel.org>,
"'Linux Kernel'" <linux-kernel@vger.kernel.org>,
"'Doug Anderson'" <dianders@chromium.org>, <kuabhs@chromium.org>,
"'Youghandhar Chintala'" <youghand@codeaurora.org>
Subject: RE: [PATCH] ath10k: Remove voltage regulator votes during wifi disable
Date: Fri, 11 Dec 2020 11:15:42 +0530 [thread overview]
Message-ID: <000301d6cf80$e0c44150$a24cc3f0$@codeaurora.org> (raw)
In-Reply-To: <CA+ASDXN4uLsbo7uuO7WPaUBY+mqHQRfdMHJ4R9KBqqmiVQJUcA@mail.gmail.com>
> -----Original Message-----
> From: Brian Norris <briannorris@chromium.org>
> Sent: Thursday, December 10, 2020 11:44 PM
> To: Rakesh Pillai <pillair@codeaurora.org>
> Cc: ath10k <ath10k@lists.infradead.org>; linux-wireless <linux-
> wireless@vger.kernel.org>; Linux Kernel <linux-kernel@vger.kernel.org>;
> Doug Anderson <dianders@chromium.org>; kuabhs@chromium.org;
> Youghandhar Chintala <youghand@codeaurora.org>
> Subject: Re: [PATCH] ath10k: Remove voltage regulator votes during wifi
> disable
>
> On Thu, Dec 10, 2020 at 7:09 AM Rakesh Pillai <pillair@codeaurora.org>
> wrote:
> > --- a/drivers/net/wireless/ath/ath10k/snoc.c
> > +++ b/drivers/net/wireless/ath/ath10k/snoc.c
> > @@ -1045,14 +1085,18 @@ static int ath10k_snoc_hif_power_up(struct
> ath10k *ar,
> > ret = ath10k_snoc_init_pipes(ar);
> > if (ret) {
> > ath10k_err(ar, "failed to initialize CE: %d\n", ret);
> > - goto err_wlan_enable;
> > + goto err_free_rri;
> > }
> >
> > return 0;
> >
> > -err_wlan_enable:
> > +err_free_rri:
> > + ath10k_ce_free_rri(ar);
>
> This change in the error path seems to be an unrelated (but correct)
> fix. It deserves its own patch, I think.
Sure Brian. I will post this error handling fix as a separate patch, and also post a v2 for this patchset.
prev parent reply other threads:[~2020-12-11 5:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 15:09 [PATCH] ath10k: Remove voltage regulator votes during wifi disable Rakesh Pillai
2020-12-10 18:13 ` Brian Norris
2020-12-11 5:45 ` Rakesh Pillai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000301d6cf80$e0c44150$a24cc3f0$@codeaurora.org' \
--to=pillair@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=kuabhs@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=youghand@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).