public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: "'John W. Linville'" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
	'Jingoo Han' <jg1.han@samsung.com>,
	'Stanislav Yakovlev' <stas.yakovlev@gmail.com>
Subject: [PATCH 1/3] wireless: ipw2100: remove unnecessary pci_set_drvdata()
Date: Mon, 25 Nov 2013 10:49:53 +0900	[thread overview]
Message-ID: <000601cee980$a2d1b0a0$e87511e0$%han@samsung.com> (raw)

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/net/wireless/ipw2x00/ipw2100.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ipw2x00/ipw2100.c b/drivers/net/wireless/ipw2x00/ipw2100.c
index f8ab193..2f4233a 100644
--- a/drivers/net/wireless/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/ipw2x00/ipw2100.c
@@ -6362,7 +6362,6 @@ out:
 				   &ipw2100_attribute_group);
 
 		free_libipw(dev, 0);
-		pci_set_drvdata(pci_dev, NULL);
 	}
 
 	pci_iounmap(pci_dev, ioaddr);
-- 
1.7.10.4



             reply	other threads:[~2013-11-25  1:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25  1:49 Jingoo Han [this message]
2013-11-25  1:51 ` [PATCH 2/3] wireless: prism54: remove unnecessary pci_set_drvdata() Jingoo Han
2013-11-25  1:52 ` [PATCH 3/3] wireless: rt2x00: " Jingoo Han
2013-11-25 14:15   ` Gertjan van Wingerde
2013-11-26  6:55 ` [PATCH 1/3] wireless: ipw2100: " Stanislav Yakovlev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000601cee980$a2d1b0a0$e87511e0$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=stas.yakovlev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox