RE: [PATCH rtw-next 4/4] wifi: rtw88: Don't set SUPPORTS_AMSDU_IN_AMPDU for RTL8814AU

[Ping-Ke Shih <pkshih@realtek.com>]

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> Sent: Friday, March 14, 2025 4:20 AM
> RTL8814AU doesn't work well with SUPPORTS_AMSDU_IN_AMPDU. The RX speed
> is noticeably lower and the VHT RX statistics are strange. Typical
> values with SUPPORTS_AMSDU_IN_AMPDU:
> 
> Reverse mode, remote host 192.168.0.1 is sending
> [  5] local 192.168.0.50 port 60710 connected to 192.168.0.1 port 5201
> [ ID] Interval           Transfer     Bitrate
> [  5]   0.00-1.00   sec  74.6 MBytes   626 Mbits/sec
> [  5]   1.00-2.00   sec  79.2 MBytes   665 Mbits/sec
> [  5]   2.00-3.00   sec  84.9 MBytes   712 Mbits/sec
> [  5]   3.00-4.00   sec  83.8 MBytes   703 Mbits/sec
> [  5]   4.00-5.00   sec  85.9 MBytes   720 Mbits/sec
> [  5]   5.00-6.00   sec  78.9 MBytes   662 Mbits/sec
> [  5]   6.00-7.00   sec  81.2 MBytes   682 Mbits/sec
> [  5]   7.00-8.00   sec  80.5 MBytes   675 Mbits/sec
> [  5]   8.00-9.00   sec  79.4 MBytes   666 Mbits/sec
> [  5]   9.00-10.00  sec  82.2 MBytes   689 Mbits/sec
> [  5]  10.00-11.00  sec  82.0 MBytes   688 Mbits/sec
> [  5]  11.00-12.00  sec  84.2 MBytes   707 Mbits/sec
> [  5]  12.00-13.00  sec  71.0 MBytes   596 Mbits/sec
> [  5]  13.00-14.00  sec  69.4 MBytes   582 Mbits/sec
> [  5]  14.00-15.00  sec  80.2 MBytes   673 Mbits/sec
> [  5]  15.00-16.00  sec  74.5 MBytes   625 Mbits/sec
> 
> [Rx Counter]:
>  * CCA (CCK, OFDM, Total) = (0, 2455, 2455)
>  * False Alarm (CCK, OFDM, Total) = (0, 69, 69)
>  * CCK cnt (ok, err) = (0, 0)
>  * OFDM cnt (ok, err) = (1239, 2)
>  * HT cnt (ok, err) = (0, 0)
>  * VHT cnt (ok, err) = (21, 12109)
> 
> The "VHT ok" number is not believable.

Since these counters are from BB, I don't doubt this is USB specific problem.
But really not sure what BB happens on receiving long packets.
So, let's take this workaround that improves over 100Mbits/sec.

> 
> And without SUPPORTS_AMSDU_IN_AMPDU:
> 
> Reverse mode, remote host 192.168.0.1 is sending
> [  5] local 192.168.0.50 port 50030 connected to 192.168.0.1 port 5201
> [ ID] Interval           Transfer     Bitrate
> [  5]   0.00-1.00   sec  70.5 MBytes   591 Mbits/sec
> [  5]   1.00-2.00   sec  86.9 MBytes   729 Mbits/sec
> [  5]   2.00-3.00   sec  98.6 MBytes   827 Mbits/sec
> [  5]   3.00-4.00   sec  97.4 MBytes   817 Mbits/sec
> [  5]   4.00-5.00   sec  98.6 MBytes   827 Mbits/sec
> [  5]   5.00-6.00   sec  96.9 MBytes   813 Mbits/sec
> [  5]   6.00-7.00   sec  98.2 MBytes   824 Mbits/sec
> [  5]   7.00-8.00   sec  98.0 MBytes   822 Mbits/sec
> [  5]   8.00-9.00   sec  99.9 MBytes   838 Mbits/sec
> [  5]   9.00-10.00  sec  99.2 MBytes   833 Mbits/sec
> [  5]  10.00-11.00  sec  98.0 MBytes   822 Mbits/sec
> [  5]  11.00-12.00  sec  98.1 MBytes   823 Mbits/sec
> [  5]  12.00-13.00  sec  97.0 MBytes   814 Mbits/sec
> [  5]  13.00-14.00  sec  98.2 MBytes   824 Mbits/sec
> [  5]  14.00-15.00  sec  98.5 MBytes   826 Mbits/sec
> [  5]  15.00-16.00  sec  97.4 MBytes   817 Mbits/sec
> 
> [Rx Counter]:
>  * CCA (CCK, OFDM, Total) = (0, 3860, 3860)
>  * False Alarm (CCK, OFDM, Total) = (0, 2, 2)
>  * CCK cnt (ok, err) = (0, 0)
>  * OFDM cnt (ok, err) = (1486, 0)
>  * HT cnt (ok, err) = (0, 0)
>  * VHT cnt (ok, err) = (7399, 9118)
> 
> Add a new member "amsdu_in_ampdu" in struct rtw_chip_info and use it
> to set SUPPORTS_AMSDU_IN_AMPDU only for the other chips.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>