Re: [PATCH] mwifiex: use is_zero_ether_addr() instead of memcmp()

Re: [PATCH] mwifiex: use is_zero_ether_addr() instead of memcmp()

[Wei Yongjun]

Hi Zhao,

On 08/24/2012 02:28 AM, Bing Zhao wrote:
> Hi Wei,
>
> Thanks for the patch.
>
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> Using is_zero_ether_addr() instead of directly use
>> memcmp() to determine if the ethernet address is all
>> zeros.
>>
>> spatch with a semantic match is used to found this problem.
>> (http://coccinelle.lip6.fr/)
> Apparently there are two more occurrences of zero_mac (scan.c:843)

This is part is special:

memcmp(scan_cfg_out->specific_bssid, &zero_mac, sizeof(zero_mac)))

&zero_mac equal zero_mac, but it missing to spatch.


>  and bc_mac (sta_cmd.c:596).
> But I can fix them when I get the chance.

This part will be sent in other patch which using
is_broadcast_ether_addr()

>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> Acked-by: Bing Zhao <bzhao@marvell.com>
>
> Thanks,
> Bing
>
>> ---
>>  drivers/net/wireless/mwifiex/sta_cmdresp.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/mwifiex/sta_cmdresp.c b/drivers/net/wireless/mwifiex/sta_cmdresp.c
>> index 0b09004..a2a33dc 100644
>> --- a/drivers/net/wireless/mwifiex/sta_cmdresp.c
>> +++ b/drivers/net/wireless/mwifiex/sta_cmdresp.c
>> @@ -17,6 +17,8 @@
>>   * this warranty disclaimer.
>>   */
>>
>> +#include <linux/etherdevice.h>
>> +
>>  #include "decl.h"
>>  #include "ioctl.h"
>>  #include "util.h"
>> @@ -736,7 +738,6 @@ static int mwifiex_ret_ibss_coalescing_status(struct mwifiex_private *priv,
>>  {
>>  	struct host_cmd_ds_802_11_ibss_status *ibss_coal_resp =
>>  					&(resp->params.ibss_coalescing);
>> -	u8 zero_mac[ETH_ALEN] = { 0, 0, 0, 0, 0, 0 };
>>
>>  	if (le16_to_cpu(ibss_coal_resp->action) == HostCmd_ACT_GEN_SET)
>>  		return 0;
>> @@ -745,7 +746,7 @@ static int mwifiex_ret_ibss_coalescing_status(struct mwifiex_private *priv,
>>  		"info: new BSSID %pM\n", ibss_coal_resp->bssid);
>>
>>  	/* If rsp has NULL BSSID, Just return..... No Action */
>> -	if (!memcmp(ibss_coal_resp->bssid, zero_mac, ETH_ALEN)) {
>> +	if (is_zero_ether_addr(ibss_coal_resp->bssid)) {
>>  		dev_warn(priv->adapter->dev, "new BSSID is NULL\n");
>>  		return 0;
>>  	}
>>
>
>

RE: [PATCH] mwifiex: use is_zero_ether_addr() instead of memcmp()

[Bing Zhao]

> > Apparently there are two more occurrences of zero_mac (scan.c:843)
> 
> This is part is special:
> 
> memcmp(scan_cfg_out->specific_bssid, &zero_mac, sizeof(zero_mac)))
> 
> &zero_mac equal zero_mac, but it missing to spatch.

I will take care of this then.

Thanks,
Bing

Which Mailing List Should I Use?

[J. C. Jones]

Hi All,
I sent a message to ath9k-devel@lists.ath9k.org a few days ago (fragment of
message below), and it was rejected multiple times. I have not received any
messages from that list since.

Did I miss anything? 

Best Regards,

-JC

Delivery to the following recipient failed permanently:

     ath9k-devel@lists.ath9k.org

Technical details of permanent failure: 
The recipient server did not accept our requests to connect. Learn more at
http://support.google.com/mail/bin/answer.py?answer=7720
[(0) lists.ath9k.org. [194.45.26.84]:25: Connection refused]

Re: Which Mailing List Should I Use?

[Pavel Roskin]

Quoting "J. C. Jones" <jaibuduvin@gmail.com>:

> Hi All,
> I sent a message to ath9k-devel@lists.ath9k.org a few days ago (fragment of
> message below), and it was rejected multiple times. I have not received any
> messages from that list since.

The ath5k and ath9k mailing lists are currently down.  Their  
administrator is on vacation now and cannot fix the server remotely.

Sorry for the inconvenience.  Please use this list for now.

-- 
Regards,
Pavel Roskin

RE: Which Mailing List Should I Use?

[J. C. Jones]

Thanks so much Pavel. I was starting to feel embarrassed for not knowing what I was doing wrong. :D

Regards,
-JC
-----Original Message-----
From: Pavel Roskin [mailto:proski@gnu.org] 
Sent: Thursday, August 23, 2012 11:04 PM
To: J. C. Jones
Cc: linux-wireless@vger.kernel.org
Subject: Re: Which Mailing List Should I Use?

Quoting "J. C. Jones" <jaibuduvin@gmail.com>:

> Hi All,
> I sent a message to ath9k-devel@lists.ath9k.org a few days ago 
> (fragment of message below), and it was rejected multiple times. I 
> have not received any messages from that list since.

The ath5k and ath9k mailing lists are currently down.  Their administrator is on vacation now and cannot fix the server remotely.

Sorry for the inconvenience.  Please use this list for now.

--
Regards,
Pavel Roskin
-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2012.0.2197 / Virus Database: 2437/5220 - Release Date: 08/23/12