* [PATCH 01/12] wireless: iwlwifi: remove unnecessary pci_set_drvdata()
2013-09-10 11:14 [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata() Jingoo Han
@ 2013-09-10 11:16 ` Jingoo Han
2013-09-10 11:30 ` Emmanuel Grumbach
2013-09-10 11:18 ` [PATCH 02/12] wireless: rtlwifi: " Jingoo Han
` (10 subsequent siblings)
11 siblings, 1 reply; 19+ messages in thread
From: Jingoo Han @ 2013-09-10 11:16 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Johannes Berg',
'Emmanuel Grumbach', ilw
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/iwlwifi/pcie/drv.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/pcie/drv.c b/drivers/net/wireless/iwlwifi/pcie/drv.c
index dc02cb9..5c5c423 100644
--- a/drivers/net/wireless/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/iwlwifi/pcie/drv.c
@@ -349,7 +349,6 @@ out_free_drv:
iwl_drv_stop(trans_pcie->drv);
out_free_trans:
iwl_trans_pcie_free(iwl_trans);
- pci_set_drvdata(pdev, NULL);
return ret;
}
@@ -360,8 +359,6 @@ static void iwl_pci_remove(struct pci_dev *pdev)
iwl_drv_stop(trans_pcie->drv);
iwl_trans_pcie_free(trans);
-
- pci_set_drvdata(pdev, NULL);
}
#ifdef CONFIG_PM_SLEEP
--
1.7.10.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 01/12] wireless: iwlwifi: remove unnecessary pci_set_drvdata()
2013-09-10 11:16 ` [PATCH 01/12] wireless: iwlwifi: " Jingoo Han
@ 2013-09-10 11:30 ` Emmanuel Grumbach
0 siblings, 0 replies; 19+ messages in thread
From: Emmanuel Grumbach @ 2013-09-10 11:30 UTC (permalink / raw)
To: Jingoo Han
Cc: John W. Linville, linux-wireless, Johannes Berg,
Emmanuel Grumbach, ilw@linux.intel.com
On Tue, Sep 10, 2013 at 2:16 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/net/wireless/iwlwifi/pcie/drv.c | 3 ---
> 1 file changed, 3 deletions(-)
>
I picked it up - thanks.
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 02/12] wireless: rtlwifi: remove unnecessary pci_set_drvdata()
2013-09-10 11:14 [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-10 11:16 ` [PATCH 01/12] wireless: iwlwifi: " Jingoo Han
@ 2013-09-10 11:18 ` Jingoo Han
2013-09-10 14:34 ` Larry Finger
2013-09-10 11:19 ` [PATCH 03/12] wireless: iwlegacy: " Jingoo Han
` (9 subsequent siblings)
11 siblings, 1 reply; 19+ messages in thread
From: Jingoo Han @ 2013-09-10 11:18 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Larry Finger',
'Chaoming Li'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/rtlwifi/pci.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index 703f839..2b6d3e0 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -2009,7 +2009,6 @@ fail2:
fail1:
if (hw)
ieee80211_free_hw(hw);
- pci_set_drvdata(pdev, NULL);
pci_disable_device(pdev);
return err;
@@ -2064,8 +2063,6 @@ void rtl_pci_disconnect(struct pci_dev *pdev)
rtl_pci_disable_aspm(hw);
- pci_set_drvdata(pdev, NULL);
-
ieee80211_free_hw(hw);
}
EXPORT_SYMBOL(rtl_pci_disconnect);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 02/12] wireless: rtlwifi: remove unnecessary pci_set_drvdata()
2013-09-10 11:18 ` [PATCH 02/12] wireless: rtlwifi: " Jingoo Han
@ 2013-09-10 14:34 ` Larry Finger
0 siblings, 0 replies; 19+ messages in thread
From: Larry Finger @ 2013-09-10 14:34 UTC (permalink / raw)
To: Jingoo Han
Cc: 'John W. Linville', linux-wireless, 'Chaoming Li'
On 09/10/2013 06:18 AM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/net/wireless/rtlwifi/pci.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
> index 703f839..2b6d3e0 100644
> --- a/drivers/net/wireless/rtlwifi/pci.c
> +++ b/drivers/net/wireless/rtlwifi/pci.c
> @@ -2009,7 +2009,6 @@ fail2:
> fail1:
> if (hw)
> ieee80211_free_hw(hw);
> - pci_set_drvdata(pdev, NULL);
> pci_disable_device(pdev);
>
> return err;
> @@ -2064,8 +2063,6 @@ void rtl_pci_disconnect(struct pci_dev *pdev)
>
> rtl_pci_disable_aspm(hw);
>
> - pci_set_drvdata(pdev, NULL);
> -
> ieee80211_free_hw(hw);
> }
> EXPORT_SYMBOL(rtl_pci_disconnect);
>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 03/12] wireless: iwlegacy: remove unnecessary pci_set_drvdata()
2013-09-10 11:14 [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-10 11:16 ` [PATCH 01/12] wireless: iwlwifi: " Jingoo Han
2013-09-10 11:18 ` [PATCH 02/12] wireless: rtlwifi: " Jingoo Han
@ 2013-09-10 11:19 ` Jingoo Han
2013-09-10 11:22 ` [PATCH 04/12] wireless: adm8211: " Jingoo Han
` (8 subsequent siblings)
11 siblings, 0 replies; 19+ messages in thread
From: Jingoo Han @ 2013-09-10 11:19 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Stanislaw Gruszka'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/iwlegacy/3945-mac.c | 2 --
drivers/net/wireless/iwlegacy/4965-mac.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/net/wireless/iwlegacy/3945-mac.c b/drivers/net/wireless/iwlegacy/3945-mac.c
index 9581d07..dea3b50 100644
--- a/drivers/net/wireless/iwlegacy/3945-mac.c
+++ b/drivers/net/wireless/iwlegacy/3945-mac.c
@@ -3811,7 +3811,6 @@ out_iounmap:
out_pci_release_regions:
pci_release_regions(pdev);
out_pci_disable_device:
- pci_set_drvdata(pdev, NULL);
pci_disable_device(pdev);
out_ieee80211_free_hw:
ieee80211_free_hw(il->hw);
@@ -3888,7 +3887,6 @@ il3945_pci_remove(struct pci_dev *pdev)
iounmap(il->hw_base);
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
il_free_channel_map(il);
il_free_geos(il);
diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
index 5ab50a5..3982ab7 100644
--- a/drivers/net/wireless/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/iwlegacy/4965-mac.c
@@ -6706,7 +6706,6 @@ out_free_eeprom:
out_iounmap:
iounmap(il->hw_base);
out_pci_release_regions:
- pci_set_drvdata(pdev, NULL);
pci_release_regions(pdev);
out_pci_disable_device:
pci_disable_device(pdev);
@@ -6787,7 +6786,6 @@ il4965_pci_remove(struct pci_dev *pdev)
iounmap(il->hw_base);
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
il4965_uninit_drv(il);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 04/12] wireless: adm8211: remove unnecessary pci_set_drvdata()
2013-09-10 11:14 [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata() Jingoo Han
` (2 preceding siblings ...)
2013-09-10 11:19 ` [PATCH 03/12] wireless: iwlegacy: " Jingoo Han
@ 2013-09-10 11:22 ` Jingoo Han
2013-09-10 11:23 ` [PATCH 05/12] wireless: airo: " Jingoo Han
` (7 subsequent siblings)
11 siblings, 0 replies; 19+ messages in thread
From: Jingoo Han @ 2013-09-10 11:22 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Thomas Huehn',
'Karl Beldan'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/adm8211.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
index f9a24e5..cfce83e 100644
--- a/drivers/net/wireless/adm8211.c
+++ b/drivers/net/wireless/adm8211.c
@@ -1924,7 +1924,6 @@ static int adm8211_probe(struct pci_dev *pdev,
pci_iounmap(pdev, priv->map);
err_free_dev:
- pci_set_drvdata(pdev, NULL);
ieee80211_free_hw(dev);
err_free_reg:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 05/12] wireless: airo: remove unnecessary pci_set_drvdata()
2013-09-10 11:14 [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata() Jingoo Han
` (3 preceding siblings ...)
2013-09-10 11:22 ` [PATCH 04/12] wireless: adm8211: " Jingoo Han
@ 2013-09-10 11:23 ` Jingoo Han
2013-09-10 11:25 ` [PATCH 06/12] wireless: ath10k: " Jingoo Han
` (6 subsequent siblings)
11 siblings, 0 replies; 19+ messages in thread
From: Jingoo Han @ 2013-09-10 11:23 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'David Howells'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/airo.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
index 7fe1964..edf4b57 100644
--- a/drivers/net/wireless/airo.c
+++ b/drivers/net/wireless/airo.c
@@ -5570,7 +5570,6 @@ static void airo_pci_remove(struct pci_dev *pdev)
airo_print_info(dev->name, "Unregistering...");
stop_airo_card(dev, 1);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
}
static int airo_pci_suspend(struct pci_dev *pdev, pm_message_t state)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 06/12] wireless: ath10k: remove unnecessary pci_set_drvdata()
2013-09-10 11:14 [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata() Jingoo Han
` (4 preceding siblings ...)
2013-09-10 11:23 ` [PATCH 05/12] wireless: airo: " Jingoo Han
@ 2013-09-10 11:25 ` Jingoo Han
2013-09-10 21:56 ` Kalle Valo
2013-09-12 16:23 ` Kalle Valo
2013-09-10 11:26 ` [PATCH 07/12] wireless: wil6210: " Jingoo Han
` (5 subsequent siblings)
11 siblings, 2 replies; 19+ messages in thread
From: Jingoo Han @ 2013-09-10 11:25 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Kalle Valo',
ath10k
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/ath/ath10k/pci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index e2f9ef5..5ef0422 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -2414,7 +2414,6 @@ err_region:
err_device:
pci_disable_device(pdev);
err_ar:
- pci_set_drvdata(pdev, NULL);
ath10k_core_destroy(ar);
err_ar_pci:
/* call HIF PCI free here */
@@ -2442,7 +2441,6 @@ static void ath10k_pci_remove(struct pci_dev *pdev)
ath10k_core_unregister(ar);
- pci_set_drvdata(pdev, NULL);
pci_iounmap(pdev, ar_pci->mem);
pci_release_region(pdev, BAR_NUM);
pci_clear_master(pdev);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 06/12] wireless: ath10k: remove unnecessary pci_set_drvdata()
2013-09-10 11:25 ` [PATCH 06/12] wireless: ath10k: " Jingoo Han
@ 2013-09-10 21:56 ` Kalle Valo
2013-09-11 0:32 ` Jingoo Han
2013-09-12 16:23 ` Kalle Valo
1 sibling, 1 reply; 19+ messages in thread
From: Kalle Valo @ 2013-09-10 21:56 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'John W. Linville', linux-wireless, ath10k
Jingoo Han <jg1.han@samsung.com> writes:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Thanks, look good. Do you want me to apply this to my ath.git tree or
are you planning to send this via some other route?
--
Kalle Valo
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 06/12] wireless: ath10k: remove unnecessary pci_set_drvdata()
2013-09-10 21:56 ` Kalle Valo
@ 2013-09-11 0:32 ` Jingoo Han
0 siblings, 0 replies; 19+ messages in thread
From: Jingoo Han @ 2013-09-11 0:32 UTC (permalink / raw)
To: 'Kalle Valo'
Cc: 'John W. Linville', linux-wireless, ath10k,
'Jingoo Han'
On Wednesday, September 11, 2013 6:57 AM, Kalle Valo wrote:
> Jingoo Han <jg1.han@samsung.com> writes:
>
> > The driver core clears the driver data to NULL after device_release
> > or on probe failure. Thus, it is not needed to manually clear the
> > device driver data to NULL.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>
> Thanks, look good. Do you want me to apply this to my ath.git tree or
> are you planning to send this via some other route?
>
Hi Kalle Valo,
It would be good that you apply this to your ath.git tree.
Thank you. :-)
Best regards,
Jingoo Han
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 06/12] wireless: ath10k: remove unnecessary pci_set_drvdata()
2013-09-10 11:25 ` [PATCH 06/12] wireless: ath10k: " Jingoo Han
2013-09-10 21:56 ` Kalle Valo
@ 2013-09-12 16:23 ` Kalle Valo
1 sibling, 0 replies; 19+ messages in thread
From: Kalle Valo @ 2013-09-12 16:23 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'John W. Linville', linux-wireless, ath10k
Jingoo Han <jg1.han@samsung.com> writes:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Thanks, applied.
--
Kalle Valo
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 07/12] wireless: wil6210: remove unnecessary pci_set_drvdata()
2013-09-10 11:14 [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata() Jingoo Han
` (5 preceding siblings ...)
2013-09-10 11:25 ` [PATCH 06/12] wireless: ath10k: " Jingoo Han
@ 2013-09-10 11:26 ` Jingoo Han
2013-09-15 7:46 ` Vladimir Kondratiev
2013-09-10 11:27 ` [PATCH 08/12] wireless: ipw2x00: " Jingoo Han
` (4 subsequent siblings)
11 siblings, 1 reply; 19+ messages in thread
From: Jingoo Han @ 2013-09-10 11:26 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han',
'Vladimir Kondratiev', wil6210
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/ath/wil6210/pcie_bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wil6210/pcie_bus.c b/drivers/net/wireless/ath/wil6210/pcie_bus.c
index eb1dc7a..eeceab3 100644
--- a/drivers/net/wireless/ath/wil6210/pcie_bus.c
+++ b/drivers/net/wireless/ath/wil6210/pcie_bus.c
@@ -197,7 +197,6 @@ static void wil_pcie_remove(struct pci_dev *pdev)
pci_iounmap(pdev, wil->csr);
pci_release_region(pdev, 0);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
}
static DEFINE_PCI_DEVICE_TABLE(wil6210_pcie_ids) = {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 07/12] wireless: wil6210: remove unnecessary pci_set_drvdata()
2013-09-10 11:26 ` [PATCH 07/12] wireless: wil6210: " Jingoo Han
@ 2013-09-15 7:46 ` Vladimir Kondratiev
0 siblings, 0 replies; 19+ messages in thread
From: Vladimir Kondratiev @ 2013-09-15 7:46 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'John W. Linville', linux-wireless, wil6210
On Tuesday, September 10, 2013 08:26:13 PM Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/net/wireless/ath/wil6210/pcie_bus.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wil6210/pcie_bus.c b/drivers/net/wireless/ath/wil6210/pcie_bus.c
> index eb1dc7a..eeceab3 100644
> --- a/drivers/net/wireless/ath/wil6210/pcie_bus.c
> +++ b/drivers/net/wireless/ath/wil6210/pcie_bus.c
> @@ -197,7 +197,6 @@ static void wil_pcie_remove(struct pci_dev *pdev)
> pci_iounmap(pdev, wil->csr);
> pci_release_region(pdev, 0);
> pci_disable_device(pdev);
> - pci_set_drvdata(pdev, NULL);
> }
>
> static DEFINE_PCI_DEVICE_TABLE(wil6210_pcie_ids) = {
>
Here is my
Acked-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 08/12] wireless: ipw2x00: remove unnecessary pci_set_drvdata()
2013-09-10 11:14 [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata() Jingoo Han
` (6 preceding siblings ...)
2013-09-10 11:26 ` [PATCH 07/12] wireless: wil6210: " Jingoo Han
@ 2013-09-10 11:27 ` Jingoo Han
2013-09-10 11:27 ` [PATCH 09/12] wireless: mwl8k: " Jingoo Han
` (3 subsequent siblings)
11 siblings, 0 replies; 19+ messages in thread
From: Jingoo Han @ 2013-09-10 11:27 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han',
'Stanislav Yakovlev'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/ipw2x00/ipw2200.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ipw2x00/ipw2200.c b/drivers/net/wireless/ipw2x00/ipw2200.c
index 6b823a1..f394af7 100644
--- a/drivers/net/wireless/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/ipw2x00/ipw2200.c
@@ -11885,7 +11885,6 @@ static int ipw_pci_probe(struct pci_dev *pdev,
pci_release_regions(pdev);
out_pci_disable_device:
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
out_free_libipw:
free_libipw(priv->net_dev, 0);
out:
@@ -11966,7 +11965,6 @@ static void ipw_pci_remove(struct pci_dev *pdev)
iounmap(priv->hw_base);
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
/* wiphy_unregister needs to be here, before free_libipw */
wiphy_unregister(priv->ieee->wdev.wiphy);
kfree(priv->ieee->a_band.channels);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 09/12] wireless: mwl8k: remove unnecessary pci_set_drvdata()
2013-09-10 11:14 [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata() Jingoo Han
` (7 preceding siblings ...)
2013-09-10 11:27 ` [PATCH 08/12] wireless: ipw2x00: " Jingoo Han
@ 2013-09-10 11:27 ` Jingoo Han
2013-09-10 11:29 ` [PATCH 10/12] wireless: orinoco: " Jingoo Han
` (2 subsequent siblings)
11 siblings, 0 replies; 19+ messages in thread
From: Jingoo Han @ 2013-09-10 11:27 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han', 'Lennert Buytenhek'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/mwl8k.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
index a3707fd..b953ad6 100644
--- a/drivers/net/wireless/mwl8k.c
+++ b/drivers/net/wireless/mwl8k.c
@@ -6093,7 +6093,6 @@ err_iounmap:
if (priv->sram != NULL)
pci_iounmap(pdev, priv->sram);
- pci_set_drvdata(pdev, NULL);
ieee80211_free_hw(hw);
err_free_reg:
@@ -6147,7 +6146,6 @@ static void mwl8k_remove(struct pci_dev *pdev)
unmap:
pci_iounmap(pdev, priv->regs);
pci_iounmap(pdev, priv->sram);
- pci_set_drvdata(pdev, NULL);
ieee80211_free_hw(hw);
pci_release_regions(pdev);
pci_disable_device(pdev);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 10/12] wireless: orinoco: remove unnecessary pci_set_drvdata()
2013-09-10 11:14 [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata() Jingoo Han
` (8 preceding siblings ...)
2013-09-10 11:27 ` [PATCH 09/12] wireless: mwl8k: " Jingoo Han
@ 2013-09-10 11:29 ` Jingoo Han
2013-09-10 11:30 ` [PATCH 11/12] wireless: p54pci: " Jingoo Han
2013-09-10 11:32 ` [PATCH 12/12] wireless: rtl818x: " Jingoo Han
11 siblings, 0 replies; 19+ messages in thread
From: Jingoo Han @ 2013-09-10 11:29 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han',
'Alexey Khoroshilov', 'Kumar Amit Mehta'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/orinoco/orinoco_nortel.c | 2 --
drivers/net/wireless/orinoco/orinoco_pci.c | 2 --
drivers/net/wireless/orinoco/orinoco_plx.c | 2 --
drivers/net/wireless/orinoco/orinoco_tmd.c | 2 --
4 files changed, 8 deletions(-)
diff --git a/drivers/net/wireless/orinoco/orinoco_nortel.c b/drivers/net/wireless/orinoco/orinoco_nortel.c
index d73fdf6..ffb2469 100644
--- a/drivers/net/wireless/orinoco/orinoco_nortel.c
+++ b/drivers/net/wireless/orinoco/orinoco_nortel.c
@@ -234,7 +234,6 @@ static int orinoco_nortel_init_one(struct pci_dev *pdev,
free_irq(pdev->irq, priv);
fail_irq:
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
fail_alloc:
@@ -265,7 +264,6 @@ static void orinoco_nortel_remove_one(struct pci_dev *pdev)
orinoco_if_del(priv);
free_irq(pdev->irq, priv);
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
pci_iounmap(pdev, priv->hw.iobase);
pci_iounmap(pdev, card->attr_io);
diff --git a/drivers/net/wireless/orinoco/orinoco_pci.c b/drivers/net/wireless/orinoco/orinoco_pci.c
index 677bf14..5ae1191 100644
--- a/drivers/net/wireless/orinoco/orinoco_pci.c
+++ b/drivers/net/wireless/orinoco/orinoco_pci.c
@@ -184,7 +184,6 @@ static int orinoco_pci_init_one(struct pci_dev *pdev,
free_irq(pdev->irq, priv);
fail_irq:
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
fail_alloc:
@@ -205,7 +204,6 @@ static void orinoco_pci_remove_one(struct pci_dev *pdev)
orinoco_if_del(priv);
free_irq(pdev->irq, priv);
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
pci_iounmap(pdev, priv->hw.iobase);
pci_release_regions(pdev);
diff --git a/drivers/net/wireless/orinoco/orinoco_plx.c b/drivers/net/wireless/orinoco/orinoco_plx.c
index 2559dbd..bbd36d1 100644
--- a/drivers/net/wireless/orinoco/orinoco_plx.c
+++ b/drivers/net/wireless/orinoco/orinoco_plx.c
@@ -273,7 +273,6 @@ static int orinoco_plx_init_one(struct pci_dev *pdev,
free_irq(pdev->irq, priv);
fail_irq:
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
fail_alloc:
@@ -301,7 +300,6 @@ static void orinoco_plx_remove_one(struct pci_dev *pdev)
orinoco_if_del(priv);
free_irq(pdev->irq, priv);
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
pci_iounmap(pdev, priv->hw.iobase);
pci_iounmap(pdev, card->attr_io);
diff --git a/drivers/net/wireless/orinoco/orinoco_tmd.c b/drivers/net/wireless/orinoco/orinoco_tmd.c
index 42afeee..04b08de 100644
--- a/drivers/net/wireless/orinoco/orinoco_tmd.c
+++ b/drivers/net/wireless/orinoco/orinoco_tmd.c
@@ -170,7 +170,6 @@ static int orinoco_tmd_init_one(struct pci_dev *pdev,
free_irq(pdev->irq, priv);
fail_irq:
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
fail_alloc:
@@ -195,7 +194,6 @@ static void orinoco_tmd_remove_one(struct pci_dev *pdev)
orinoco_if_del(priv);
free_irq(pdev->irq, priv);
- pci_set_drvdata(pdev, NULL);
free_orinocodev(priv);
pci_iounmap(pdev, priv->hw.iobase);
pci_iounmap(pdev, card->bridge_io);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 11/12] wireless: p54pci: remove unnecessary pci_set_drvdata()
2013-09-10 11:14 [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata() Jingoo Han
` (9 preceding siblings ...)
2013-09-10 11:29 ` [PATCH 10/12] wireless: orinoco: " Jingoo Han
@ 2013-09-10 11:30 ` Jingoo Han
2013-09-10 11:32 ` [PATCH 12/12] wireless: rtl818x: " Jingoo Han
11 siblings, 0 replies; 19+ messages in thread
From: Jingoo Han @ 2013-09-10 11:30 UTC (permalink / raw)
To: 'John W. Linville'
Cc: linux-wireless, 'Jingoo Han',
'Christian Lamparter', 'Alexey Khoroshilov',
'Larry Finger'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/p54/p54pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/p54/p54pci.c b/drivers/net/wireless/p54/p54pci.c
index 57e3af8..f9a07b0 100644
--- a/drivers/net/wireless/p54/p54pci.c
+++ b/drivers/net/wireless/p54/p54pci.c
@@ -631,7 +631,6 @@ static int p54p_probe(struct pci_dev *pdev,
iounmap(priv->map);
err_free_dev:
- pci_set_drvdata(pdev, NULL);
p54_free_common(dev);
err_free_reg:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 12/12] wireless: rtl818x: remove unnecessary pci_set_drvdata()
2013-09-10 11:14 [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata() Jingoo Han
` (10 preceding siblings ...)
2013-09-10 11:30 ` [PATCH 11/12] wireless: p54pci: " Jingoo Han
@ 2013-09-10 11:32 ` Jingoo Han
11 siblings, 0 replies; 19+ messages in thread
From: Jingoo Han @ 2013-09-10 11:32 UTC (permalink / raw)
To: 'John W. Linville'; +Cc: linux-wireless, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/rtl818x/rtl8180/dev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/rtl818x/rtl8180/dev.c b/drivers/net/wireless/rtl818x/rtl8180/dev.c
index fc207b2..a91506b 100644
--- a/drivers/net/wireless/rtl818x/rtl8180/dev.c
+++ b/drivers/net/wireless/rtl818x/rtl8180/dev.c
@@ -1122,7 +1122,6 @@ static int rtl8180_probe(struct pci_dev *pdev,
iounmap(priv->map);
err_free_dev:
- pci_set_drvdata(pdev, NULL);
ieee80211_free_hw(dev);
err_free_reg:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 19+ messages in thread