From: Jingoo Han <jg1.han@samsung.com>
To: "'John W. Linville'" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
'Jingoo Han' <jg1.han@samsung.com>,
'Stanislav Yakovlev' <stas.yakovlev@gmail.com>
Subject: [PATCH 08/12] wireless: ipw2x00: remove unnecessary pci_set_drvdata()
Date: Tue, 10 Sep 2013 20:27:09 +0900 [thread overview]
Message-ID: <00b901ceae18$afc7fb50$0f57f1f0$%han@samsung.com> (raw)
In-Reply-To: <00b101ceae16$ecb87c30$c6297490$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/ipw2x00/ipw2200.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ipw2x00/ipw2200.c b/drivers/net/wireless/ipw2x00/ipw2200.c
index 6b823a1..f394af7 100644
--- a/drivers/net/wireless/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/ipw2x00/ipw2200.c
@@ -11885,7 +11885,6 @@ static int ipw_pci_probe(struct pci_dev *pdev,
pci_release_regions(pdev);
out_pci_disable_device:
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
out_free_libipw:
free_libipw(priv->net_dev, 0);
out:
@@ -11966,7 +11965,6 @@ static void ipw_pci_remove(struct pci_dev *pdev)
iounmap(priv->hw_base);
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
/* wiphy_unregister needs to be here, before free_libipw */
wiphy_unregister(priv->ieee->wdev.wiphy);
kfree(priv->ieee->a_band.channels);
--
1.7.10.4
next prev parent reply other threads:[~2013-09-10 11:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 11:14 [PATCH 0/11] wireless: remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-10 11:16 ` [PATCH 01/12] wireless: iwlwifi: " Jingoo Han
2013-09-10 11:30 ` Emmanuel Grumbach
2013-09-10 11:18 ` [PATCH 02/12] wireless: rtlwifi: " Jingoo Han
2013-09-10 14:34 ` Larry Finger
2013-09-10 11:19 ` [PATCH 03/12] wireless: iwlegacy: " Jingoo Han
2013-09-10 11:22 ` [PATCH 04/12] wireless: adm8211: " Jingoo Han
2013-09-10 11:23 ` [PATCH 05/12] wireless: airo: " Jingoo Han
2013-09-10 11:25 ` [PATCH 06/12] wireless: ath10k: " Jingoo Han
2013-09-10 21:56 ` Kalle Valo
2013-09-11 0:32 ` Jingoo Han
2013-09-12 16:23 ` Kalle Valo
2013-09-10 11:26 ` [PATCH 07/12] wireless: wil6210: " Jingoo Han
2013-09-15 7:46 ` Vladimir Kondratiev
2013-09-10 11:27 ` Jingoo Han [this message]
2013-09-10 11:27 ` [PATCH 09/12] wireless: mwl8k: " Jingoo Han
2013-09-10 11:29 ` [PATCH 10/12] wireless: orinoco: " Jingoo Han
2013-09-10 11:30 ` [PATCH 11/12] wireless: p54pci: " Jingoo Han
2013-09-10 11:32 ` [PATCH 12/12] wireless: rtl818x: " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00b901ceae18$afc7fb50$0f57f1f0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stas.yakovlev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).