From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D10C31E40 for ; Sat, 13 Jul 2019 19:58:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBEF92063F for ; Sat, 13 Jul 2019 19:58:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727961AbfGMT6k (ORCPT ); Sat, 13 Jul 2019 15:58:40 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:40476 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727943AbfGMT6j (ORCPT ); Sat, 13 Jul 2019 15:58:39 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hmOAH-0004eP-Hb; Sat, 13 Jul 2019 21:58:37 +0200 Message-ID: <0112d5d6a0c83dbb800811b414ca1d5b3266e9dd.camel@sipsolutions.net> Subject: Re: [PATCH] mac80211: add IEEE80211_KEY_FLAG_PUT_MMIE_SPACE to ieee80211_key_flags From: Johannes Berg To: Lorenzo Bianconi Cc: linux-wireless@vger.kernel.org, nbd@nbd.name Date: Sat, 13 Jul 2019 21:58:35 +0200 In-Reply-To: <1dd6dd782121d0b9cc32dec6a01db474e568ffb2.1563030033.git.lorenzo@kernel.org> References: <1dd6dd782121d0b9cc32dec6a01db474e568ffb2.1563030033.git.lorenzo@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-3.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sat, 2019-07-13 at 17:03 +0200, Lorenzo Bianconi wrote: > Add IEEE80211_KEY_FLAG_PUT_MMIE_SPACE flag to ieee80211_key_flags in order > to allow the driver to notify mac80211 to allocate mmie space for AES_CMAC > hw cipher. Moreover mac80211 will set MMIE pn while MIC will be computed > in hw. Hmm. It probably should be called something like GENERATE_MMIE in line with GENERATE_IV_MGMT etc.? Purely adding the *space* wouldn't really be all that useful, we're not really going to apply our tailroom request to this since it's a (relatively rare) mgmt. frame, so ... johannes