Re: [PATCH] wifi: rtw88: Fix the RX aggregation in USB 3 mode

[Bitterblue Smith <rtl8821cerfe2@gmail.com>]

On 09/10/2024 03:18, Ping-Ke Shih wrote:
> Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
>> RTL8822CU, RTL8822BU, and RTL8821CU don't need BIT_EN_PRE_CALC.
>> In fact, RTL8822BU in USB 3 mode doesn't pass all the frames to the
>> driver, resulting in much lower download speed than normal:
> 
> Have you also tested in USB 2 mode? Just want to know this patch works on
> both modes. 
> 

Yes, USB 2 mode was working before and it still works after this patch.

>> [  5]   0.00-10.00  sec  98.6 MBytes  82.7 Mbits/sec                  receiver
>>
>> Don't set BIT_EN_PRE_CALC. Then the speed is much better:
>>
>> [  5]   0.00-10.00  sec   714 MBytes   599 Mbits/sec                  receiver
> 
> Good job. That improves ten times of RX throughput!
> 
>>
>> Fixes: 002a5db9a52a ("wifi: rtw88: Enable USB RX aggregation for 8822c/8822b/8821c")
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> 
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> 
>> ---
>> The code in the official drivers is a little broken. It sets
>> BIT_EN_PRE_CALC and then immediately unsets it. I didn't notice that
>> before.
>>
>> Maybe this should go to kernel 6.12, if it's not too late. Commit 002a5db9a52a
>> ("wifi: rtw88: Enable USB RX aggregation for 8822c/8822b/8821c") first appears
>> in 6.12.
> 
> Kalle, could you help to take this patch via wireless tree? If yes, I will
> assign this to you in patchwork. 
> 
>