From: P Praneesh <ppranees@codeaurora.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: Jouni Malinen <jouni@codeaurora.org>,
Kalle Valo <kvalo@codeaurora.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
Karthikeyan Periyasamy <periyasa@codeaurora.org>
Subject: Re: [PATCH 12/12] ath11k: avoid unnecessary lock contention in tx_completion path
Date: Wed, 30 Jun 2021 10:47:51 +0530 [thread overview]
Message-ID: <01aa763e6a2cd58139a6b3685b8151a7@codeaurora.org> (raw)
In-Reply-To: <b1dbd11a-e978-16ea-1473-7eb81399981c@nbd.name>
On 2021-06-29 23:05, Felix Fietkau wrote:
> On 2021-06-15 23:14, Jouni Malinen wrote:
>> From: P Praneesh <ppranees@codeaurora.org>
>>
>> Lock is not needed for the readable idr operation, so avoid
>> spin_lock_bh
>> for the idr_find() call. No need to disable the bottom half preempt if
>> it is already in bottom half context, so modify the spin_lock_bh to
>> spin_lock in the data tx completion handler.
>>
>> Tested-on: IPQ8074 hw2.0 AHB
>> WLAN.HK.2.4.0.1-01734-QCAHKSWPL_SILICONZ-1 v2
>>
>> Co-developed-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
>> Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
>> Signed-off-by: P Praneesh <ppranees@codeaurora.org>
>> Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
>> ---
>> drivers/net/wireless/ath/ath11k/dp_tx.c | 18 ++++++++----------
>> 1 file changed, 8 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c
>> b/drivers/net/wireless/ath/ath11k/dp_tx.c
>> index ab9ccf0eb274..659f9d98bc0c 100644
>> --- a/drivers/net/wireless/ath/ath11k/dp_tx.c
>> +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c
>> @@ -288,19 +288,18 @@ static void ath11k_dp_tx_free_txbuf(struct
>> ath11k_base *ab, u8 mac_id,
>> struct sk_buff *msdu;
>> struct ath11k_skb_cb *skb_cb;
>>
>> - spin_lock_bh(&tx_ring->tx_idr_lock);
>> msdu = idr_find(&tx_ring->txbuf_idr, msdu_id);
>> - if (!msdu) {
>> + if (unlikely(!msdu)) {
>> ath11k_warn(ab, "tx completion for unknown msdu_id %d\n",
>> msdu_id);
>> - spin_unlock_bh(&tx_ring->tx_idr_lock);
>> return;
>> }
>>
>> skb_cb = ATH11K_SKB_CB(msdu);
>>
>> + spin_lock(&tx_ring->tx_idr_lock);
>> idr_remove(&tx_ring->txbuf_idr, msdu_id);
> Why are you doing the lookups twice instead of just using the return
> value of idr_remove?
>
> - Felix
Yes, we will address this in the next version of the patch.
prev parent reply other threads:[~2021-06-30 5:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 21:13 [PATCH 00/12] ath11k: optimizations in data path Jouni Malinen
2021-06-15 21:13 ` [PATCH 01/12] ath11k: disable unused CE8 interrupts for ipq8074 Jouni Malinen
2021-06-15 21:13 ` [PATCH 02/12] ath11k: allocate dst ring descriptors from cacheable memory Jouni Malinen
2021-06-28 15:19 ` Jeff Johnson
2021-06-15 21:13 ` [PATCH 03/12] ath11k: modify dp_rx desc access wrapper calls inline Jouni Malinen
2021-06-15 21:13 ` [PATCH 04/12] ath11k: avoid additional access to ath11k_hal_srng_dst_num_free Jouni Malinen
2021-06-15 21:14 ` [PATCH 05/12] ath11k: avoid active pdev check for each msdu Jouni Malinen
2021-06-15 21:14 ` [PATCH 06/12] ath11k: remove usage quota while processing rx packets Jouni Malinen
2021-06-15 21:14 ` [PATCH 07/12] ath11k: add branch predictors in process_rx Jouni Malinen
2021-06-15 21:14 ` [PATCH 08/12] ath11k: allocate HAL_WBM2SW_RELEASE ring from cacheable memory Jouni Malinen
2021-06-15 21:14 ` [PATCH 09/12] ath11k: remove mod operator in dst ring processing Jouni Malinen
2021-06-15 21:14 ` [PATCH 10/12] ath11k: avoid while loop in ring selection of tx completion interrupt Jouni Malinen
2021-06-15 21:14 ` [PATCH 11/12] ath11k: add branch predictors in dp_tx path Jouni Malinen
2021-06-15 21:14 ` [PATCH 12/12] ath11k: avoid unnecessary lock contention in tx_completion path Jouni Malinen
2021-06-29 17:35 ` Felix Fietkau
2021-06-30 5:17 ` P Praneesh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01aa763e6a2cd58139a6b3685b8151a7@codeaurora.org \
--to=ppranees@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=jouni@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=periyasa@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).