From: Ping-Ke Shih <pkshih@realtek.com>
To: Kevin Lo <kevlo@kevlo.org>, Kalle Valo <kvalo@kernel.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Bitterblue Smith <rtl8821cerfe2@gmail.com>,
Jes Sorensen <Jes.Sorensen@gmail.com>
Subject: RE: [PATCH v2] wifi: rtl8xxxu: 8188f: no need to initialize interrupts
Date: Tue, 2 May 2023 09:10:04 +0000 [thread overview]
Message-ID: <02a6f536d1a144749d97db5c301ee76c@realtek.com> (raw)
In-Reply-To: <ZEtpDi8oCr0E9scd@ns.kevlo.org>
> -----Original Message-----
> From: Kevin Lo <kevlo@kevlo.org>
> Sent: Friday, April 28, 2023 2:35 PM
> To: Kalle Valo <kvalo@kernel.org>
> Cc: linux-wireless@vger.kernel.org; Bitterblue Smith <rtl8821cerfe2@gmail.com>; Jes Sorensen
> <Jes.Sorensen@gmail.com>; Ping-Ke Shih <pkshih@realtek.com>
> Subject: Re: [PATCH v2] wifi: rtl8xxxu: 8188f: no need to initialize interrupts
>
> On Fri, Apr 28, 2023 at 08:40:34AM +0300, Kalle Valo wrote:
> >
> > Kevin Lo <kevlo@kevlo.org> writes:
> >
> > > There's no need to initialize interrupts for RTL8188FTV like the vendor driver.
> > >
> > > Signed-off-by: Kevin Lo <kevlo@kevlo.org>
> >
> > Why do this, what's the benefit? Or is this just a theoretical fix. The
> > commit log should explain this.
>
> If I understand correctly, just like rtw88 usb devices, rtl8xxxu has no
> hardware interrupt.
>
With/without hardware interrupt, it depends on IMR (interrupt mask register)
setting. If it is enabled, driver can receive C2H, PS indicators, and beacon
TBTT events via certain USB endpoint. But, normally vendor driver doesn't
use them neither.
Why it initializes interrupt in this patch is to reset ISR (interrupt status
register) to avoid unexpected interrupts are received. So, if it doesn't
really enable interrupt by IMR, I suppose it should work well even without
this patch.
Kevin, could I know the real problem you met?
Ping-Ke
next prev parent reply other threads:[~2023-05-02 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 2:34 [PATCH v2] wifi: rtl8xxxu: 8188f: no need to initialize interrupts Kevin Lo
2023-04-28 5:40 ` Kalle Valo
2023-04-28 6:34 ` Kevin Lo
2023-05-02 9:10 ` Ping-Ke Shih [this message]
2023-05-05 5:27 ` Kevin Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02a6f536d1a144749d97db5c301ee76c@realtek.com \
--to=pkshih@realtek.com \
--cc=Jes.Sorensen@gmail.com \
--cc=kevlo@kevlo.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).