Re: [PATCH] wifi: mac80211: fix assigning channel in activate links

[Johannes Berg <johannes@sipsolutions.net>]

> +		/*
> +		 * inform about the link info changed parameters after all
> +		 * stations are also added
> +		 */

I don't understand that comment - you're not doing anything with the
stations here? And per the commit log it's explicitly _not_ after doing
the AP station. I'm not sure we should set up everything before the AP
station?

> +						  BSS_CHANGED_HE_BSS_COLOR);
> +
> +	}

You make it look like you just moved code but also snuck in a new blank
line :)

johannes

> +
>  	for_each_set_bit(link_id, &rem, IEEE80211_MLD_MAX_NUM_LINKS) {
>  		struct ieee80211_link_data *link;

I also think you put this code too early now - you're now first using
more channel contexts by way of _ieee80211_link_use_channel() before you
even release the ones from deactivated ("rem" bitmap in this code)
links. That doesn't seem like it could work correctly in general.

johannes